Re: [PATCH v9 2/2] s390: virtio: PV needs VIRTIO I/O device protection

[Pierre Morel <pmorel@linux.ibm.com>]

On 2020-08-21 14:05, Cornelia Huck wrote:
> On Wed, 19 Aug 2020 18:23:18 +0200
> Pierre Morel <pmorel@linux.ibm.com> wrote:
> 
>> If protected virtualization is active on s390, VIRTIO has retricted
> 
> s/retricted/only restricted/
> 
>> access to the guest memory.
>> Define CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS and export
>> arch_has_restricted_virtio_memory_access to advertize VIRTIO if that's
>> the case, preventing a host error on access attempt.
>>
>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>> ---
>>   arch/s390/Kconfig   |  1 +
>>   arch/s390/mm/init.c | 11 +++++++++++
>>   2 files changed, 12 insertions(+)
> 
> (...)
> 
>> diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c
>> index 6dc7c3b60ef6..8febd73ed6ca 100644
>> --- a/arch/s390/mm/init.c
>> +++ b/arch/s390/mm/init.c
>> @@ -45,6 +45,7 @@
>>   #include <asm/kasan.h>
>>   #include <asm/dma-mapping.h>
>>   #include <asm/uv.h>
>> +#include <linux/virtio_config.h>
> 
> I don't think you need this include anymore.

right,
> 
>>   
>>   pgd_t swapper_pg_dir[PTRS_PER_PGD] __section(.bss..swapper_pg_dir);
>>   
> 
> (...)
> 
> With the nit fixed,
> 
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> 

Thanks,

Pierre

-- 
Pierre Morel
IBM Lab Boeblingen