public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@linux.ibm.com>
To: David Hildenbrand <david@redhat.com>,
	Eric Farman <farman@linux.ibm.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>
Subject: Re: [PATCH] KVM: s390: vsie: retry SIE instruction on host intercepts
Date: Mon, 4 Mar 2024 09:44:52 +0100	[thread overview]
Message-ID: <1deb0e32-7351-45d2-a342-96a659402be8@linux.ibm.com> (raw)
In-Reply-To: <338544a6-4838-4eeb-b1b2-2faa6c11c1be@redhat.com>



Am 04.03.24 um 09:35 schrieb David Hildenbrand:
> On 01.03.24 21:43, Eric Farman wrote:
>> It's possible that SIE exits for work that the host needs to perform
>> rather than something that is intended for the guest.
>>
>> A Linux guest will ignore this intercept code since there is nothing
>> for it to do, but a more robust solution would rewind the PSW back to
>> the SIE instruction. This will transparently resume the guest once
>> the host completes its work, without the guest needing to process
>> what is effectively a NOP and re-issue SIE itself.
> 
> I recall that 0-intercepts are valid by the architecture. Further, I recall that there were some rather tricky corner cases where avoiding 0-intercepts would not be that easy.
> 
> Now, it's been a while ago, and maybe I misremember. SoI'm trusting people with access to documentation can review this.

Yes, 0-intercepts are allowed, and this also happens when LPAR has an exit.
So this patch is not necessary, the question is if this would be an valuable optimization?

  reply	other threads:[~2024-03-04  8:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01 20:43 [PATCH] KVM: s390: vsie: retry SIE instruction on host intercepts Eric Farman
2024-03-04  8:35 ` David Hildenbrand
2024-03-04  8:44   ` Christian Borntraeger [this message]
2024-03-04 15:37     ` Eric Farman
2024-04-29 10:18       ` Christian Borntraeger
2024-04-30 19:31         ` Eric Farman
2024-07-03 14:59         ` Janosch Frank
2024-07-03 17:45           ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1deb0e32-7351-45d2-a342-96a659402be8@linux.ibm.com \
    --to=borntraeger@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=farman@linux.ibm.com \
    --cc=frankja@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox