public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc: thuth@redhat.com, linux-s390@vger.kernel.org,
	borntraeger@de.ibm.com, cohuck@redhat.com
Subject: Re: [PATCH v2 10/10] s390x: Fix library constant definitions
Date: Fri, 24 Apr 2020 12:13:23 +0200	[thread overview]
Message-ID: <1ffe6eca-0f17-939e-ecf4-2719c455cb6f@redhat.com> (raw)
In-Reply-To: <20200423091013.11587-11-frankja@linux.ibm.com>

On 23.04.20 11:10, Janosch Frank wrote:
> Seems like I uppercased the whole region instead of only the ULs when
> I added those definitions. Let's make the x lowercase again.
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> ---
>  lib/s390x/asm/arch_def.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h
> index 15a4d49..1b3bb0c 100644
> --- a/lib/s390x/asm/arch_def.h
> +++ b/lib/s390x/asm/arch_def.h
> @@ -19,10 +19,10 @@ struct psw {
>  #define PSW_MASK_DAT			0x0400000000000000UL
>  #define PSW_MASK_PSTATE			0x0001000000000000UL
>  
> -#define CR0_EXTM_SCLP			0X0000000000000200UL
> -#define CR0_EXTM_EXTC			0X0000000000002000UL
> -#define CR0_EXTM_EMGC			0X0000000000004000UL
> -#define CR0_EXTM_MASK			0X0000000000006200UL
> +#define CR0_EXTM_SCLP			0x0000000000000200UL
> +#define CR0_EXTM_EXTC			0x0000000000002000UL
> +#define CR0_EXTM_EMGC			0x0000000000004000UL
> +#define CR0_EXTM_MASK			0x0000000000006200UL
>  
>  struct lowcore {
>  	uint8_t		pad_0x0000[0x0080 - 0x0000];	/* 0x0000 */
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb

      reply	other threads:[~2020-04-24 10:13 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23  9:10 [PATCH v2 00/10] s390x: smp: Improve smp code part 2 Janosch Frank
2020-04-23  9:10 ` [PATCH v2 01/10] s390x: smp: Test all CRs on initial reset Janosch Frank
2020-04-23 15:39   ` David Hildenbrand
2020-04-24  9:33     ` [PATCH v3] " Janosch Frank
2020-04-24 10:03       ` David Hildenbrand
2020-04-23  9:10 ` [PATCH v2 02/10] s390x: smp: Dirty fpc before initial reset test Janosch Frank
2020-04-23  9:10 ` [PATCH v2 03/10] s390x: smp: Test stop and store status on a running and stopped cpu Janosch Frank
2020-04-23 16:03   ` David Hildenbrand
2020-04-23  9:10 ` [PATCH v2 04/10] s390x: smp: Test local interrupts after cpu reset Janosch Frank
2020-04-24 10:07   ` David Hildenbrand
2020-04-24 11:51     ` Janosch Frank
2020-04-23  9:10 ` [PATCH v2 05/10] s390x: smp: Loop if secondary cpu returns into cpu setup again Janosch Frank
2020-04-24 10:08   ` David Hildenbrand
2020-04-23  9:10 ` [PATCH v2 06/10] s390x: smp: Remove unneeded cpu loops Janosch Frank
2020-04-23  9:10 ` [PATCH v2 07/10] s390x: smp: Use full PSW to bringup new cpu Janosch Frank
2020-04-24 10:09   ` David Hildenbrand
2020-04-24 11:16     ` Janosch Frank
2020-04-24 11:23       ` David Hildenbrand
2020-04-24 11:31         ` Janosch Frank
2020-04-23  9:10 ` [PATCH v2 08/10] s390x: smp: Wait for sigp completion Janosch Frank
2020-04-24 10:11   ` David Hildenbrand
2020-04-24 11:40     ` Janosch Frank
2020-04-29  8:57       ` Janosch Frank
2020-04-29  9:06         ` David Hildenbrand
2020-04-29  9:37           ` Janosch Frank
2020-04-29  9:55             ` David Hildenbrand
2020-04-29 11:21               ` Janosch Frank
2020-04-29 11:47                 ` David Hildenbrand
2020-04-29 12:09                   ` Janosch Frank
2020-04-29 12:15                     ` David Hildenbrand
2020-04-23  9:10 ` [PATCH v2 09/10] s390x: smp: Add restart when running test Janosch Frank
2020-04-24 10:13   ` David Hildenbrand
2020-04-23  9:10 ` [PATCH v2 10/10] s390x: Fix library constant definitions Janosch Frank
2020-04-24 10:13   ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ffe6eca-0f17-939e-ecf4-2719c455cb6f@redhat.com \
    --to=david@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox