From: David Miller <davem@davemloft.net>
To: braunu@de.ibm.com
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org, fpavlic@de.ibm.com
Subject: Re: [patch 2/3] s390: iucv - avoid deadlock between iucv_path_connect and tasklet
Date: Sat, 14 Jul 2007 19:03:50 -0700 (PDT) [thread overview]
Message-ID: <20070714.190350.95894917.davem@davemloft.net> (raw)
In-Reply-To: <20070713085245.495093000@linux.vnet.ibm.com>
From: Ursula Braun <braunu@de.ibm.com>
Date: Fri, 13 Jul 2007 10:50:55 +0200
> From: Ursula Braun <braunu@de.ibm.com>
>
> An iucv deadlock may occur, where one CPU is spinning on the
> iucv_table_lock for iucv_tasklet_fn(), while another CPU is holding
> the iucv_table_lock for an iucv_path_connect() and is waiting for
> the first CPU in an smp_call_function.
> Solution: replace spin_lock in iucv_tasklet_fn by spin_trylock and
> reschedule tasklet in case of non-granted lock.
>
> Signed-off-by: Ursula Braun <braunu@de.ibm.com>
> Acked-by: Frank Pavlic <fpavlic@de.ibm.com>
Applied.
next prev parent reply other threads:[~2007-07-15 2:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 8:50 [patch 0/3] [AF_IUCV/IUCV] fixes for net-2.6.23 Ursula Braun
2007-07-13 8:50 ` [patch 1/3] From: Jennifer Hunt <jenhunt@us.ibm.com> Ursula Braun
2007-07-15 2:03 ` David Miller
2007-07-13 8:50 ` [patch 2/3] s390: iucv - avoid deadlock between iucv_path_connect and tasklet Ursula Braun
2007-07-15 2:03 ` David Miller [this message]
2007-07-13 8:50 ` [patch 3/3] s390: af_iucv: add lock when updating accept_q Ursula Braun
2007-07-15 2:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070714.190350.95894917.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=braunu@de.ibm.com \
--cc=fpavlic@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox