Re: [PATCH 04/10] [SG] Update drivers to use sg helpers

[Heiko Carstens <heiko.carstens@de.ibm.com>]

On Tue, Oct 23, 2007 at 09:14:07AM +0200, Jens Axboe wrote:
> On Tue, Oct 23 2007, Heiko Carstens wrote:
> > On Mon, Oct 22, 2007 at 08:10:58PM +0200, Jens Axboe wrote:
> > > Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
> > > ---
> > 
> > You forgot s390's zfcp driver. But unfortunately the trivial fix below
> > doesn't work. No more I/O possible. Swen and/or Christof could you
> > provide a correct fix for this please? Thanks!
> > 
> > ---
> >  drivers/s390/scsi/zfcp_def.h |    4 ++--
> >  drivers/s390/scsi/zfcp_erp.c |    4 ++--
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > Index: linux-2.6/drivers/s390/scsi/zfcp_def.h
> > ===================================================================
> > --- linux-2.6.orig/drivers/s390/scsi/zfcp_def.h
> > +++ linux-2.6/drivers/s390/scsi/zfcp_def.h
> > @@ -63,7 +63,7 @@
> >  static inline void *
> >  zfcp_sg_to_address(struct scatterlist *list)
> >  {
> > -	return (void *) (page_address(list->page) + list->offset);
> > +	return (void *) (page_address(sg_page(list) + list->offset));
> >  }
> 
> return sg_virt(list); would be better.
> 
> I'll fix up the driver, no worries.

ok, thanks!