Linux s390 Architecture development
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: frank.blaschka@de.ibm.com
Cc: jgarzik@pobox.com, netdev@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [patch 0/4] s390: qeth fixes 2.6.29
Date: Mon, 15 Dec 2008 00:46:07 -0800 (PST)	[thread overview]
Message-ID: <20081215.004607.228873135.davem@davemloft.net> (raw)
In-Reply-To: <20081211132309.053505000@de.ibm.com>

From: frank.blaschka@de.ibm.com
Date: Thu, 11 Dec 2008 14:23:09 +0100

> here are some fixes for 2.6.29
> The patches apply to linux-next

They do not apply to net-next-2.6, as just one example patch #2 has
part of the patch saying:

@@ -1207,12 +1207,9 @@ static int qeth_l3_start_ipa_source_mac(
 
 	QETH_DBF_TEXT(TRACE, 3, "stsrcmac");
 
-	if (!card->options.fake_ll)
-		return -EOPNOTSUPP;
-
 	if (!qeth_is_supported(card, IPA_SOURCE_MAC)) {
 		dev_info(&card->gdev->dev,
-			"Inbound source address not supported on %s\n",
+			"Inbound source MAC-address not supported on %s\n",
 			QETH_CARD_IFNAME(card));
 		return -EOPNOTSUPP;
 	}

Yet that "dev_info" is a PRINT_INFO in the net-next-2.6 tree.

Please resend patches which apply cleanly to my tree and I'll apply
them.

Thank you.

      parent reply	other threads:[~2008-12-15  8:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-11 13:23 [patch 0/4] s390: qeth fixes 2.6.29 frank.blaschka
2008-12-11 13:23 ` [patch 1/4] qeth: HiperSockets mcl string conversion (pre z9 mach) frank.blaschka
2008-12-11 13:23 ` [patch 2/4] qeth: exploit source MAC address for inbound layer3 packets frank.blaschka
2008-12-11 13:23 ` [patch 3/4] qeth: avoid crash in case of layer mismatch for VSWITCH frank.blaschka
2008-12-11 13:23 ` [patch 4/4] qeth: do not spin for SETIP ip assist command frank.blaschka
2008-12-15  8:46 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081215.004607.228873135.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=frank.blaschka@de.ibm.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox