From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Stoyan Gaydarov <stoyboyker@gmail.com>
Cc: linux-kernel@vger.kernel.org, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com, linux-s390@vger.kernel.org
Subject: Re: [PATCH 09/25] [s390] BUG to BUG_ON changes
Date: Tue, 10 Mar 2009 12:17:54 +0100 [thread overview]
Message-ID: <200903101217.54927.borntraeger@de.ibm.com> (raw)
In-Reply-To: <1236661850-8237-10-git-send-email-stoyboyker@gmail.com>
Am Tuesday 10 March 2009 06:10:34 schrieb Stoyan Gaydarov:
> +++ b/drivers/s390/char/tape_std.c
> @@ -39,8 +39,8 @@ tape_std_assign_timeout(unsigned long data)
> int rc;
>
> request = (struct tape_request *) data;
> - if ((device = request->device) == NULL)
> - BUG();
> + device = request->device;
> + BUG_ON(device == NULL);
>
> DBF_EVENT(3, "%08x: Assignment timeout. Device busy.\n",
> device->cdev_id);
Most of the patch look good. Since !pointer seems to be preferred over
pointer == NULL, this hunk can be changed to
BUG_ON(!device);
Christian
prev parent reply other threads:[~2009-03-10 11:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1236661850-8237-1-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-2-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-3-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-4-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-5-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-6-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-7-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-8-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-9-git-send-email-stoyboyker@gmail.com>
2009-03-10 5:10 ` [PATCH 09/25] [s390] BUG to BUG_ON changes Stoyan Gaydarov
2009-03-10 11:17 ` Christian Borntraeger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903101217.54927.borntraeger@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=stoyboyker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox