From: David Miller <davem@davemloft.net>
To: blaschka@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [patch 0/6] s390: qeth fixes for 2.6.30
Date: Wed, 25 Mar 2009 16:47:04 -0700 (PDT) [thread overview]
Message-ID: <20090325.164704.89679614.davem@davemloft.net> (raw)
In-Reply-To: <49C9EA6A.90808@linux.vnet.ibm.com>
From: Frank Blaschka <blaschka@linux.vnet.ibm.com>
Date: Wed, 25 Mar 2009 09:25:14 +0100
> > Your EDDP was slow because the implementation was incredibly
> > sub-optimal. %90 of the code is doing copies and fiddling
> > with SKB internals.
>
> I did not wrote the EDDP code but this was my impression too. Thanks for
> confirming my study. Also the filling of the hardware buffers was not
> efficient and passing more buffers to the hw was expensive too.
I keep meaning to get back to a project I was working on that
would make generic the by-hand TSO that drivers such as
drivers/net/sfc/ are doing.
Just like this EDDP code seems to have been doing, they claim
to be TSO capable as a device but it is all done in software.
The hope is to write a generic framework, and skb_dma_map() and
skb_dma_unmap() were created as initial infrastructure for that.
Anyways, if I ever complete that project, drivers like qeth
could try to make use of it and do some perf tests.
prev parent reply other threads:[~2009-03-25 23:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 6:57 [patch 0/6] s390: qeth fixes for 2.6.30 frank.blaschka
2009-03-25 6:57 ` [patch 1/6] [PATCH] qeth: struct device - replace bus_id with dev_name(), dev_set_name() frank.blaschka
2009-03-25 6:57 ` [patch 2/6] [PATCH] qeth: add statistics for tx csum frank.blaschka
2009-03-25 6:57 ` [patch 3/6] [PATCH] qeth: remove EDDP frank.blaschka
2009-03-25 6:57 ` [patch 4/6] [PATCH] qeth: unregister MAC addresses during recovery frank.blaschka
2009-03-25 6:57 ` [patch 5/6] [PATCH] qeth: check for completion of a running recovery frank.blaschka
2009-03-25 6:57 ` [patch 6/6] [PATCH] qeth: fix wait_event_timeout handling frank.blaschka
2009-03-25 7:08 ` [patch 0/6] s390: qeth fixes for 2.6.30 David Miller
2009-03-25 8:25 ` Frank Blaschka
2009-03-25 23:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090325.164704.89679614.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=blaschka@linux.vnet.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox