From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: linux-s390@vger.kernel.org
Subject: Re: [PATCH] s390: beyond ARRAY_SIZE of irq_ptr->{in,out}put_qs
Date: Wed, 20 May 2009 06:57:17 +0000 [thread overview]
Message-ID: <20090520085717.07847c5c@skybase> (raw)
In-Reply-To: <4A134C97.1020409@gmail.com>
On Wed, 20 May 2009 02:19:35 +0200
Roel Kluin <roel.kluin@gmail.com> wrote:
> Do not go beyond ARRAY_SIZE of irq_ptr->{in,out}put_qs
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/drivers/s390/cio/qdio_main.c b/drivers/s390/cio/qdio_main.c
> index accd957..758e4b1 100644
> --- a/drivers/s390/cio/qdio_main.c
> +++ b/drivers/s390/cio/qdio_main.c
> @@ -1514,7 +1514,7 @@ int do_QDIO(struct ccw_device *cdev, unsigned int callflags,
>
> if ((bufnr > QDIO_MAX_BUFFERS_PER_Q) ||
> (count > QDIO_MAX_BUFFERS_PER_Q) ||
> - (q_nr > QDIO_MAX_QUEUES_PER_IRQ))
> + (q_nr >= QDIO_MAX_QUEUES_PER_IRQ))
> return -EINVAL;
>
> if (!count)
Nice find. I'll queue the patch to the git390 tree.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
parent reply other threads:[~2009-05-20 6:57 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <4A134C97.1020409@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090520085717.07847c5c@skybase \
--to=schwidefsky@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox