From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux390@de.ibm.com, linux-s390@vger.kernel.org
Subject: Re: [PATCH] s390: fix build failure in con3215.c tty wakeup tasklet
Date: Tue, 17 Apr 2012 18:14:55 +0200 [thread overview]
Message-ID: <20120417161455.GB4382@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <1334678829-30823-1-git-send-email-paul.gortmaker@windriver.com>
On Tue, Apr 17, 2012 at 12:07:09PM -0400, Paul Gortmaker wrote:
> Commit 86b26007a37d81e7aca242bb5b649473f8f81297 (tty-next)
>
> "TTY: con3215, use tty from tty_port"
>
> removed the tty struct from the raw struct, causing:
>
> CC drivers/s390/char/con3215.o
> drivers/s390/char/con3215.c: In function 'raw3215_wakeup':
> drivers/s390/char/con3215.c:339:16: error: 'struct raw3215_info' has no member named 'tty'
> make[2]: *** [drivers/s390/char/con3215.o] Error 1
...
> diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c
> index e928e04..759c43c 100644
> --- a/drivers/s390/char/con3215.c
> +++ b/drivers/s390/char/con3215.c
> @@ -336,7 +336,13 @@ static inline void raw3215_try_io(struct raw3215_info *raw)
> static void raw3215_wakeup(unsigned long data)
> {
> struct raw3215_info *raw = (struct raw3215_info *) data;
> - tty_wakeup(raw->tty);
> + struct tty_struct *tty = tty_port_tty_get(&raw->port);
> +
> + if (tty == NULL)
> + return;
> +
> + tty_wakeup(tty);
> + tty_kref_put(tty);
Yep, I posted a similar patch earlier:
http://marc.info/?l=linux-next&m=133466152209052&w=2
The NULL check is not necessary, because "it cannot happen" ;)
Thanks,
Heiko
prev parent reply other threads:[~2012-04-17 16:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1334135699-30180-1-git-send-email-jslaby@suse.cz>
2012-04-11 9:14 ` [PATCH 2/3] TTY: con3215, add tty_port Jiri Slaby
2012-04-11 9:14 ` [PATCH 3/3] TTY: con3215, use tty from tty_port Jiri Slaby
2012-04-17 16:07 ` [PATCH] s390: fix build failure in con3215.c tty wakeup tasklet Paul Gortmaker
2012-04-17 16:14 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417161455.GB4382@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=paul.gortmaker@windriver.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox