From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Alexander Graf <agraf@suse.de>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Carsten Otte <cotte@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
KVM <kvm@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [PATCH 4/6] KVM: s390: fix sigp set prefix status stored cases
Date: Tue, 26 Jun 2012 17:39:39 +0200 [thread overview]
Message-ID: <20120626173939.52617394@BR9GNB5Z> (raw)
In-Reply-To: <FBB4695B-5B84-4644-9C26-C037258DC20A@suse.de>
On Tue, 26 Jun 2012 16:56:08 +0200
Alexander Graf <agraf@suse.de> wrote:
>
> On 26.06.2012, at 16:06, Cornelia Huck wrote:
>
> > From: Heiko Carstens <heiko.carstens@de.ibm.com>
> >
> > If an invalid parameter is passed or the addressed cpu is in an
> > incorrect state sigp set prefix will store a status.
> > This status must only have bits set as defined by the architecture.
> > The current kvm implementation missed to clear bits and also did
> > not set the intended status bit ("and" instead of "or" operation).
> >
> > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> > Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>
> What was the net effect of this for a guest? Any problems rising from it?
The guest might see some unexpected status bits if it did call sigp set
prefix in an incorrect way. I'm not aware that anybody has actually
seen that.
Cornelia
next prev parent reply other threads:[~2012-06-26 15:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 14:06 [PATCH 0/6] kvm/s390: sigp related changes for 3.6 Cornelia Huck
2012-06-26 14:06 ` [PATCH 1/6] s390/smp: remove redundant check Cornelia Huck
2012-06-26 14:06 ` [PATCH 2/6] s390/smp/kvm: unifiy sigp definitions Cornelia Huck
2012-06-26 14:06 ` [PATCH 3/6] KVM: s390: fix sigp sense running condition code handling Cornelia Huck
2012-06-26 14:52 ` Alexander Graf
2012-06-26 15:33 ` Cornelia Huck
2012-06-26 15:36 ` Alexander Graf
2012-06-26 15:57 ` Cornelia Huck
2012-06-26 16:03 ` Alexander Graf
2012-06-26 14:06 ` [PATCH 4/6] KVM: s390: fix sigp set prefix status stored cases Cornelia Huck
2012-06-26 14:56 ` Alexander Graf
2012-06-26 15:39 ` Cornelia Huck [this message]
2012-06-26 15:42 ` Alexander Graf
2012-06-26 14:06 ` [PATCH 5/6] KVM: s390: use sigp condition code defines Cornelia Huck
2012-06-26 14:06 ` [PATCH 6/6] KVM: s390: Fix sigp sense handling Cornelia Huck
2012-06-29 23:19 ` [PATCH 0/6] kvm/s390: sigp related changes for 3.6 Marcelo Tosatti
2012-07-02 10:00 ` Martin Schwidefsky
2012-07-02 23:16 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120626173939.52617394@BR9GNB5Z \
--to=cornelia.huck@de.ibm.com \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox