From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Stelian Nirlu <steliannirlu@gmail.com>
Cc: schwidefsky@de.ibm.com, linux390@de.ibm.com,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
penberg@kernel.org
Subject: Re: [PATCH v2] s390: use kcalloc instead of kmalloc and memset
Date: Tue, 12 Mar 2013 08:07:15 +0100 [thread overview]
Message-ID: <20130312070715.GB4148@osiris> (raw)
In-Reply-To: <1363018931-9628-1-git-send-email-steliannirlu@gmail.com>
On Mon, Mar 11, 2013 at 06:22:10PM +0200, Stelian Nirlu wrote:
> Signed-off-by: Stelian Nirlu <steliannirlu@gmail.com>
> ---
> arch/s390/net/bpf_jit_comp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c
> index 0972e91..82f165f 100644
> --- a/arch/s390/net/bpf_jit_comp.c
> +++ b/arch/s390/net/bpf_jit_comp.c
> @@ -747,10 +747,9 @@ void bpf_jit_compile(struct sk_filter *fp)
>
> if (!bpf_jit_enable)
> return;
> - addrs = kmalloc(fp->len * sizeof(*addrs), GFP_KERNEL);
> + addrs = kcalloc(fp->len, sizeof(*addrs), GFP_KERNEL);
> if (addrs == NULL)
> return;
> - memset(addrs, 0, fp->len * sizeof(*addrs));
Applied, thanks!
prev parent reply other threads:[~2013-03-12 7:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 16:22 [PATCH v2] s390: use kcalloc instead of kmalloc and memset Stelian Nirlu
2013-03-12 7:07 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312070715.GB4148@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=penberg@kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=steliannirlu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox