public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: linux-s390@vger.kernel.org
Subject: Re: drivers/tty/serial/8250/8250.c:109:24: fatal error: asm/serial.h: No such file or directory
Date: Mon, 01 Apr 2013 08:41:25 +0000	[thread overview]
Message-ID: <20130401084125.GA3671@osiris> (raw)
In-Reply-To: <20130329053713.GA14438@localhost>

On Fri, Mar 29, 2013 at 01:37:13PM +0800, Fengguang Wu wrote:
> On Fri, Mar 29, 2013 at 11:47:54AM +0800, Fengguang Wu wrote:
> > Hi Paul,
> > 
> > > Hi Fengguang,
> > > 
> > > I don't think this is right.  It can't be a 14 month old change.
> > > The 2nd error itself totally smells like uapi changes.
> > > 
> > > The 1st error makes no sense at all when you look at this:
> > > 
> > > config SERIAL_8250_RUNTIME_UARTS
> > >         int "Number of 8250/16550 serial ports to register at runtime"
> > >         depends on SERIAL_8250
> > > 
> > > How can you build 8250 support and not have a value for the
> > > number of runtime UARTs, given the above?
> > > 
> > > I also just checked that mainline v3.9-rc4-158-g9064171 has no
> > > problems building drivers/tty/* for s390 while x-compiling in
> > > my local test of allmodconfig.
> > 
> > You are right! I cannot reproduce this problem in upstream and
> > linux-next. It should be some problem with my build scripts..
> 
> OK I got the root cause: the error
> 
>         drivers/tty/serial/8250/8250.c:101:24: fatal error: asm/serial.h: No such file or directory
> 
> is first detected in tree/branch
> 
>         git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git topic/r8a73a4
> 
> where 8250 is enabled on "make ARCH=s390 allmodconfig":

[...]

> The build script then start bisecting command
> 
>         make ARCH=s390 drivers/tty/serial/8250/8250.o
> 
> and goes all the way down to commit 9bef3d41973 ("serial: group all
> the 8250 related code together"), not being aware of the
> CONFIG_SERIAL_8250 was disabled in earlier kernels.

FWIW, all your build error reports with respect to s390 and generic hardirqs
seem to be wrong.
There are a couple of new different build errors in linux-next, however. *sigh*

      reply	other threads:[~2013-04-01  8:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20130329034754.GA13698@localhost>
2013-03-29  5:37 ` drivers/tty/serial/8250/8250.c:109:24: fatal error: asm/serial.h: No such file or directory Fengguang Wu
2013-04-01  8:41   ` Heiko Carstens [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130401084125.GA3671@osiris \
    --to=heiko.carstens@de.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox