From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, mingo@redhat.com, x86@kernel.org,
rth@twiddle.net, linux@arm.linux.org.uk, msalter@redhat.com,
starvik@axis.com, dhowells@redhat.com, tony.luck@intel.com,
benh@kernel.crashing.org, takata@linux-m32r.org,
geert@linux-m68k.org, james.hogan@imgtec.com, monstr@monstr.eu,
ralf@linux-mips.org, jonas@southpole.se, rkuo@codeaurora.org,
liqin.chen@sunplusct.com, davem@davemloft.net,
lethal@linux-sh.org, vgupta@synopsys.com, chris@zankel.net,
cmetcalf@tilera.com, ysato@users.sourceforge.jp,
gxt@mprc.pku.edu.cn, jdike@addtoit.com,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-s390@vger.kernel.org, Mike Frysinger <vapier@gentoo.org>,
uclinux-dist-devel@blackfin.uclinux.org,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH 3/7] dump_stack: consolidate dump_stack() implementations and unify their behaviors
Date: Thu, 4 Apr 2013 09:13:09 +0200 [thread overview]
Message-ID: <20130404091309.5c9da9d3@mschwide> (raw)
In-Reply-To: <1365016497-32033-4-git-send-email-tj@kernel.org>
On Wed, 3 Apr 2013 12:14:53 -0700
Tejun Heo <tj@kernel.org> wrote:
> v2: CPU number added to the generic debug info as requested by s390
> folks and dropped the s390 specific dump_stack(). This loses %ksp
> from the debug message which the maintainers think isn't important
> enough to keep the s390-specific dump_stack() implementation.
>
> dump_stack_print_info() is moved to kernel/printk.c from
> lib/dump_stack.c. Because linkage is per objecct file,
> dump_stack_print_info() living in the same lib file as generic
> dump_stack() means that archs which implement custom dump_stack()
> - at this point, only blackfin - can't use dump_stack_print_info()
> as that will bring in the generic version of dump_stack() too. v1
> The v1 patch broke build on blackfin due to this issue. The build
> breakage was reported by Fengguang Wu.
For the s390 changes:
Acked-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2013-04-04 7:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1365016497-32033-1-git-send-email-tj@kernel.org>
[not found] ` <20130403191453.ETAHDILwqgPLE_oLYOsJeZEwj6SXRsiT2Tv696ZmPSo@z>
2013-04-03 19:14 ` [PATCH 3/7] dump_stack: consolidate dump_stack() implementations and unify their behaviors Tejun Heo
2013-04-04 7:13 ` Martin Schwidefsky [this message]
2013-04-12 20:39 ` Chris Metcalf
2013-04-12 21:59 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130404091309.5c9da9d3@mschwide \
--to=schwidefsky@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=chris@zankel.net \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=geert@linux-m68k.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=heiko.carstens@de.ibm.com \
--cc=james.hogan@imgtec.com \
--cc=jdike@addtoit.com \
--cc=jonas@southpole.se \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=liqin.chen@sunplusct.com \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=msalter@redhat.com \
--cc=ralf@linux-mips.org \
--cc=rkuo@codeaurora.org \
--cc=rth@twiddle.net \
--cc=starvik@axis.com \
--cc=takata@linux-m32r.org \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
--cc=vgupta@synopsys.com \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox