From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Joe Perches <joe@perches.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-s390@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: arch/s390/lib/uaccess_pt.c: Missing breaks: ?
Date: Mon, 15 Apr 2013 07:58:23 +0200 [thread overview]
Message-ID: <20130415055822.GC4207@osiris> (raw)
In-Reply-To: <1366005207.1878.43.camel@joe-AO722>
On Sun, Apr 14, 2013 at 10:53:27PM -0700, Joe Perches wrote:
> On Mon, 2013-04-15 at 07:48 +0200, Heiko Carstens wrote:
> > On Sat, Apr 13, 2013 at 11:06:14PM -0700, Joe Perches wrote:
> > > Commit ea81531d ("s390/uaccess: fix page table walk")
> > > added this code. It looks like it should have break;
> > > for each case.
> > no, the fallthrough is on purpose for each case statement.
>
> Hi again. It might be useful to add /* fallthrough */
> or some other comment showing it's intentional.
I might add some comment above the function, since for everybody
*knowing* the architecture it's obvious ;) that these must be
fallthroughs.
How did you stuble across this?
next prev parent reply other threads:[~2013-04-15 5:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-14 6:06 arch/s390/lib/uaccess_pt.c: Missing breaks: ? Joe Perches
2013-04-15 5:48 ` Heiko Carstens
2013-04-15 5:53 ` Joe Perches
2013-04-15 5:58 ` Heiko Carstens [this message]
2013-04-15 6:15 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130415055822.GC4207@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox