From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Andrew Morton <akpm@linux-foundation.org>,
Ursula Braun <ursula.braun@de.ibm.com>,
s390 <linux-s390@vger.kernel.org>
Subject: Re: [patch 03/16] s390: net: lcs: Add missing destroy_timer_on_stack()
Date: Mon, 24 Mar 2014 07:22:45 +0100 [thread overview]
Message-ID: <20140324062245.GD4487@osiris> (raw)
In-Reply-To: <20140323150752.843705144@linutronix.de>
On Sun, Mar 23, 2014 at 03:09:25PM -0000, Thomas Gleixner wrote:
> Otherwise we leak a tracking object when DEBUG_OBJECTS is enabled.
> drivers/s390/net/lcs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: tip/drivers/s390/net/lcs.c
> ===================================================================
> --- tip.orig/drivers/s390/net/lcs.c
> +++ tip/drivers/s390/net/lcs.c
> @@ -899,6 +899,7 @@ lcs_send_lancmd(struct lcs_card *card, s
> add_timer(&timer);
> wait_event(reply->wait_q, reply->received);
> del_timer_sync(&timer);
> + destroy_timer_on_stack(&timer);
Applied, thanks.
next prev parent reply other threads:[~2014-03-24 6:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140323150557.288925975@linutronix.de>
2014-03-23 15:09 ` [patch 01/16] s390: tape: Use del_timer_sync() Thomas Gleixner
2014-03-24 6:22 ` Heiko Carstens
2014-03-23 15:09 ` [patch 03/16] s390: net: lcs: Add missing destroy_timer_on_stack() Thomas Gleixner
2014-03-24 6:22 ` Heiko Carstens [this message]
2014-03-23 15:09 ` [patch 02/16] s390: tape: " Thomas Gleixner
2014-03-24 6:22 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140324062245.GD4487@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=Julia.Lawall@lip6.fr \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=ursula.braun@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox