From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: linux-s390@vger.kernel.org
Subject: Re: [PATCH] lcs: replace PTR_RET with PTR_ERR_OR_ZERO
Date: Fri, 11 Apr 2014 11:46:16 +0000 [thread overview]
Message-ID: <20140411134616.541ba981@mschwide> (raw)
In-Reply-To: <1397210657-28486-1-git-send-email-duanj.fnst@cn.fujitsu.com>
On Fri, 11 Apr 2014 18:04:17 +0800
Duan Jiong <duanj.fnst@cn.fujitsu.com> wrote:
> PTR_RET is deprecated. Do not recommend its usage anymore.
> Use PTR_ERR_OR_ZERO instead.
>
> Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
> ---
> drivers/s390/net/lcs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/net/lcs.c b/drivers/s390/net/lcs.c
> index c461f2a..8d5d969 100644
> --- a/drivers/s390/net/lcs.c
> +++ b/drivers/s390/net/lcs.c
> @@ -2442,7 +2442,7 @@ __init lcs_init_module(void)
> if (rc)
> goto out_err;
> lcs_root_dev = root_device_register("lcs");
> - rc = PTR_RET(lcs_root_dev);
> + rc = PTR_ERR_OR_ZERO(lcs_root_dev);
> if (rc)
> goto register_err;
> rc = ccw_driver_register(&lcs_ccw_driver);
Applied to our internal tree and will be added to the network
patch queue. Thanks.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
parent reply other threads:[~2014-04-11 11:46 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1397210657-28486-1-git-send-email-duanj.fnst@cn.fujitsu.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140411134616.541ba981@mschwide \
--to=schwidefsky@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox