From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux390@de.ibm.com, Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Sudeep Dutt <sudeep.dutt@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nikhil Rao <nikhil.rao@intel.com>,
Wolfram Sang <wsa@the-dreams.de>,
Siva Yerramreddy <yshivakrishna@gmail.com>,
Heinz Graalfs <graalfs@linux.vnet.ibm.com>,
linux-s390@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 02/16] virtio: unify config_changed handling
Date: Mon, 6 Oct 2014 11:20:16 +0200 [thread overview]
Message-ID: <20141006112016.0227d0d3.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1412525038-15871-3-git-send-email-mst@redhat.com>
On Sun, 5 Oct 2014 19:06:52 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> Replace duplicated code in all transports with a single wrapper in
> virtio.c.
>
> The only functional change is in virtio_mmio.c: if a buggy device sends
> us an interrupt before driver is set, we previously returned IRQ_NONE,
> now we return IRQ_HANDLED.
>
> As this must not happen in practice, this does not look like a big deal.
>
> See also commit 3fff0179e33cd7d0a688dab65700c46ad089e934
> virtio-pci: do not oops on config change if driver not loaded.
> for the original motivation behind the driver check.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/linux/virtio.h | 2 ++
> drivers/misc/mic/card/mic_virtio.c | 6 +-----
> drivers/s390/kvm/kvm_virtio.c | 9 +--------
> drivers/s390/kvm/virtio_ccw.c | 6 +-----
> drivers/virtio/virtio.c | 10 ++++++++++
> drivers/virtio/virtio_mmio.c | 7 ++-----
> drivers/virtio/virtio_pci.c | 6 +-----
> 7 files changed, 18 insertions(+), 28 deletions(-)
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
prev parent reply other threads:[~2014-10-06 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1412525038-15871-1-git-send-email-mst@redhat.com>
2014-10-05 16:06 ` [PATCH 02/16] virtio: unify config_changed handling Michael S. Tsirkin
2014-10-06 9:20 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141006112016.0227d0d3.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=ashutosh.dixit@intel.com \
--cc=borntraeger@de.ibm.com \
--cc=graalfs@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=mst@redhat.com \
--cc=nikhil.rao@intel.com \
--cc=rusty@rustcorp.com.au \
--cc=schwidefsky@de.ibm.com \
--cc=sudeep.dutt@intel.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wsa@the-dreams.de \
--cc=yshivakrishna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox