From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-s390@vger.kernel.org
Subject: Re: [bug report] s390/cio: use cssid for pgid generation
Date: Mon, 16 Jan 2017 13:18:00 +0000 [thread overview]
Message-ID: <20170116131800.GE4104@mwanda> (raw)
In-Reply-To: <alpine.LFD.2.20.1701161356550.1815@schleppi>
On Mon, Jan 16, 2017 at 02:06:11PM +0100, Sebastian Ott wrote:
> Hello Dan,
>
> On Mon, 16 Jan 2017, Dan Carpenter wrote:
> > The patch c8500e120b81: "s390/cio: use cssid for pgid generation"
> > from Jun 17, 2016, leads to the following static checker warning:
> >
> > drivers/s390/cio/css.c:707 css_generate_pgid()
> > warn: impossible condition '(css->cssid < 0) => (0-255 < 0)'
> >
>
> Thanks for your report. This issue was already known and should be fixed
> by now. What's puzzling me, is that c8500e120b81 actually is the fixed
> version where cssid is a signed int. So with commit c8500e120b81 you
> should no longer see this warning.
>
Huh. You're right. I didn't read the code carefully... :/ Sorry for
the noise.
I'm not sure how this error was generated either because I can't
reproduce it today.
regards,
dan carpenter
parent reply other threads:[~2017-01-16 13:18 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <alpine.LFD.2.20.1701161356550.1815@schleppi>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116131800.GE4104@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox