From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-s390@vger.kernel.org
Subject: Re: [bug report] zfcp: trace on request for open and close of WKA port
Date: Tue, 07 Feb 2017 09:26:01 +0000 [thread overview]
Message-ID: <20170207092601.GG11103@mwanda> (raw)
In-Reply-To: <20170207092211.GA26324@mwanda>
Same thing for zfcp_fsf_close_wka_port() as well.
regards,
dan carpenter
On Tue, Feb 07, 2017 at 12:22:11PM +0300, Dan Carpenter wrote:
> Hello Steffen Maier,
>
> The patch d27a7cb91960: "zfcp: trace on request for open and close of
> WKA port" from Aug 10, 2016, leads to the following static checker
> warning:
>
> drivers/s390/scsi/zfcp_fsf.c:1615 zfcp_fsf_open_wka_port()
> warn: 'req' was already freed.
>
> drivers/s390/scsi/zfcp_fsf.c
> 1609 zfcp_fsf_start_timer(req, ZFCP_FSF_REQUEST_TIMEOUT);
> 1610 retval = zfcp_fsf_req_send(req);
> 1611 if (retval)
> 1612 zfcp_fsf_req_free(req);
> ^^^
> Freed.
>
> 1613 out:
> 1614 spin_unlock_irq(&qdio->req_q_lock);
> 1615 if (req && !IS_ERR(req))
> 1616 zfcp_dbf_rec_run_wka("fsowp_1", wka_port, req->req_id);
> ^^^^^^^^^^^
> Use after free.
>
> 1617 return retval;
> 1618 }
>
> regards,
> dan carpenter
parent reply other threads:[~2017-02-07 9:26 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20170207092211.GA26324@mwanda>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207092601.GG11103@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox