From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Himanshu Jha <himanshujha199640@gmail.com>
Cc: heiko.carstens@de.ibm.com, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/sclp: Use setup_timer and mod_timer
Date: Mon, 25 Sep 2017 07:23:55 +0200 [thread overview]
Message-ID: <20170925072355.33e0e940@mschwideX1> (raw)
In-Reply-To: <1506254414-10269-1-git-send-email-himanshujha199640@gmail.com>
On Sun, 24 Sep 2017 17:30:14 +0530
Himanshu Jha <himanshujha199640@gmail.com> wrote:
> Use setup_timer and mod_timer API instead of structure assignments.
>
> This is done using Coccinelle and semantic patch used
> for this as follows:
>
> @@
> expression x,y,z,a,b;
> @@
>
> -init_timer (&x);
> +setup_timer (&x, y, z);
> +mod_timer (&a, b);
> -x.function = y;
> -x.data = z;
> -x.expires = b;
> -add_timer(&a);
>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> ---
> drivers/s390/char/sclp_con.c | 7 ++-----
> drivers/s390/char/sclp_tty.c | 7 ++-----
> 2 files changed, 4 insertions(+), 10 deletions(-)
Added to s390/linux for the 4.15 merge window, thanks.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
prev parent reply other threads:[~2017-09-25 5:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 12:00 [PATCH] s390/sclp: Use setup_timer and mod_timer Himanshu Jha
2017-09-25 5:23 ` Martin Schwidefsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925072355.33e0e940@mschwideX1 \
--to=schwidefsky@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=himanshujha199640@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox