From: Cornelia Huck <cohuck@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Pierre Morel <pmorel@linux.vnet.ibm.com>,
Yi Min Zhao <zyimin@linux.vnet.ibm.com>,
Halil Pasic <pasic@linux.vnet.ibm.com>,
kvm@vger.kernel.org, linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [PATCH] KVM: s390: provide a capability for AIS state migration
Date: Thu, 9 Nov 2017 10:15:23 +0100 [thread overview]
Message-ID: <20171109101523.03a1feb0.cohuck@redhat.com> (raw)
In-Reply-To: <20171109090404.125475-1-borntraeger@de.ibm.com>
On Thu, 9 Nov 2017 10:04:04 +0100
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> The AIS capability was introduced in 4.12, while the interface
> to migrate the state was added in 4.13. Let's add a new capability
> that tells userspace that AIS states can be migrated.
I think that needs a bit more explanation (i.e., why can't userspace
check for the migration interface?) Also, it would be good to mention
the cap under Documentation/.
[It's very likely that we will have forgotten the history of this in
in a few month's time...]
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> arch/s390/kvm/kvm-s390.c | 1 +
> include/uapi/linux/kvm.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index de6a5b7..8f4b655 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -395,6 +395,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
> case KVM_CAP_S390_USER_INSTR0:
> case KVM_CAP_S390_CMMA_MIGRATION:
> case KVM_CAP_S390_AIS:
> + case KVM_CAP_S390_AIS_MIGRATION:
> r = 1;
> break;
> case KVM_CAP_S390_MEM_OP:
> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
> index 8388875..b605956 100644
> --- a/include/uapi/linux/kvm.h
> +++ b/include/uapi/linux/kvm.h
> @@ -930,6 +930,7 @@ struct kvm_ppc_resize_hpt {
> #define KVM_CAP_PPC_SMT_POSSIBLE 147
> #define KVM_CAP_HYPERV_SYNIC2 148
> #define KVM_CAP_HYPERV_VP_INDEX 149
> +#define KVM_CAP_S390_AIS_MIGRATION 150
>
> #ifdef KVM_CAP_IRQ_ROUTING
>
prev parent reply other threads:[~2017-11-09 9:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 9:04 [PATCH] KVM: s390: provide a capability for AIS state migration Christian Borntraeger
2017-11-09 9:15 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109101523.03a1feb0.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.vnet.ibm.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=zyimin@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox