From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
KVM <kvm@vger.kernel.org>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH v2] KVM: s390: cleanup struct kvm_s390_float_interrupt
Date: Wed, 10 Jan 2018 13:20:58 +0100 [thread overview]
Message-ID: <20180110132058.23b3e792.cohuck@redhat.com> (raw)
In-Reply-To: <e75863bd-fca2-a4b0-4e1d-c09c8b5023af@redhat.com>
On Wed, 10 Jan 2018 12:56:15 +0100
David Hildenbrand <david@redhat.com> wrote:
> On 10.01.2018 12:30, Christian Borntraeger wrote:
> >
> >
> > On 01/08/2018 08:37 PM, David Hildenbrand wrote:
> >> "wq" is not used at all. "cpuflags" can be access directly via the vcpu,
> >> just as "float_int" via vcpu->kvm.
> >
> > you also use the _set_cpuflag wrapper in several places, please add that to the patch description.
> > Otherwise this looks like a nice cleanup.
>
> Can you add that to the patch description when applying, if there are no
> other comments?
>
> "While at it, reuse _set_cpuflag() to make the code look nicer.".
>
> Thanks!
>
With that, feel free to add
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2018-01-10 12:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 19:37 [PATCH v2] KVM: s390: cleanup struct kvm_s390_float_interrupt David Hildenbrand
2018-01-09 13:55 ` Cornelia Huck
2018-01-10 11:39 ` David Hildenbrand
2018-01-10 11:51 ` Christian Borntraeger
2018-01-10 11:30 ` Christian Borntraeger
2018-01-10 11:56 ` David Hildenbrand
2018-01-10 12:20 ` Cornelia Huck [this message]
2018-01-10 13:09 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110132058.23b3e792.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox