public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Cc: Thomas-Mich Richter <tmricht@linux.vnet.ibm.com>,
	Michael Petlan <mpetlan@redhat.com>, Jiri Olsa <jolsa@redhat.com>,
	linux-perf-users@vger.kernel.org, linux-s390@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH v2 5/5] perf trace: Remove audit-libs dependency if syscall tables are present
Date: Sun, 21 Jan 2018 09:27:48 -0300	[thread overview]
Message-ID: <20180121122748.GF23453@kernel.org> (raw)
In-Reply-To: <20180119140426.GB23453@kernel.org>

Em Fri, Jan 19, 2018 at 11:04:26AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Jan 19, 2018 at 09:56:17AM +0100, Hendrik Brueckner escreveu:
> > Change the Makefile and build process to no longer require audit-libs
> > interfaces when the architecture provides system call tables.
> > 
> > Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
> > Reviewed-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
> > Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> > Cc: Jiri Olsa <jolsa@redhat.com>
> 
> So, I need this extra patch to really stop linking against
> audit-libs-devel (aka libaudit), which I merged with this 5/5 patch and
> have now in my tree, thanks for your work!

So, test building it on centos:5 fails:

  CC       /tmp/build/perf/bench/sched-messaging.o
In file included from trace/beauty/arch_errno_names.c:1,
                 from builtin-trace.c:547:
/tmp/build/perf/trace/beauty/generated/arch_errno_name_array.c:1708:2: error: no newline at end of file

I'm fixing this up.

- Arnaldo

  reply	other threads:[~2018-01-21 12:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-19  8:56 [PATCH v2 0/5] perf trace: Introduce arch-specific errno code/name mappings Hendrik Brueckner
2018-01-19  8:56 ` [PATCH v2 1/5] tools include arch: Grab a copy of errno.h for arch's supported by perf Hendrik Brueckner
2018-01-19  8:56 ` [PATCH v2 2/5] tools include asm-generic: Grab errno.h and errno-base.h Hendrik Brueckner
2018-01-19  8:56 ` [PATCH v2 3/5] perf util: Introduce architecture specific errno/name mapping Hendrik Brueckner
2018-01-19  8:56 ` [PATCH v2 4/5] perf trace: Obtain errno values by using arch_syscalls__strerrno() Hendrik Brueckner
2018-01-19  8:56 ` [PATCH v2 5/5] perf trace: Remove audit-libs dependency if syscall tables are present Hendrik Brueckner
2018-01-19 14:04   ` Arnaldo Carvalho de Melo
2018-01-21 12:27     ` Arnaldo Carvalho de Melo [this message]
2018-01-25  8:00 ` [PATCH v2 0/5] perf trace: Introduce arch-specific errno code/name mappings Ravi Bangoria
2018-01-25  9:28   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180121122748.GF23453@kernel.org \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=brueckner@linux.vnet.ibm.com \
    --cc=jolsa@redhat.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mpetlan@redhat.com \
    --cc=tmricht@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox