public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v7 06/22] s390/zcrypt: Support for apmask and aqmask change on live system
Date: Mon, 30 Jul 2018 12:46:23 +0000	[thread overview]
Message-ID: <20180730144623.254a076e.cohuck@redhat.com> (raw)
In-Reply-To: <20180726195429.31960-7-borntraeger@de.ibm.com>

On Thu, 26 Jul 2018 21:54:13 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> From: Harald Freudenberger <freude@linux.ibm.com>
> 
> This patch enables modifications of the apmask and aqmask on a live
> system. Until now these both masks are read-only on a live system. The
> only way to change these masks was via kernel command line parameter.
> 
> This patch makes the sysfs attributes /sys/bus/ap/apmask and
> /sys/bus/ap/aqmask writeable by root. With changing the mask(s) a
> revision of the existing queue to driver bindings is done. So all
> APQNs which are bound to the 'wrong' driver are reprobed via kernel
> function device_reprobe() and thus the new correct driver will be
> assigned with respect of the changed apmask and aqmask bits.

The expected input for those attributes needs to be documented.

IIRC the vfio-ap driver does not support device removal in the first
shot. So, what happens if an APQN is added to the reserved set? BUG()?

> 
> Signed-off-by: Harald Freudenberger <freude@linux.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  drivers/s390/crypto/ap_bus.c | 153 ++++++++++++++++++++++++++++++++---
>  1 file changed, 143 insertions(+), 10 deletions(-)

           reply	other threads:[~2018-07-30 12:46 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20180726195429.31960-7-borntraeger@de.ibm.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180730144623.254a076e.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox