From: David Miller <davem@davemloft.net>
To: ubraun@linux.ibm.com
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
raspl@linux.ibm.com
Subject: Re: [PATCH net 4/5] net/smc: atomic SMCD cursor handling
Date: Tue, 13 Nov 2018 14:53:47 -0800 (PST) [thread overview]
Message-ID: <20181113.145347.202584017982412625.davem@davemloft.net> (raw)
In-Reply-To: <20181112160133.16058-5-ubraun@linux.ibm.com>
From: Ursula Braun <ubraun@linux.ibm.com>
Date: Mon, 12 Nov 2018 17:01:32 +0100
> +/* SMC-D cursor format */
> +union smcd_cdc_cursor {
...
> +} __aligned(8);
> struct smcd_cdc_msg {
...
> + union smcd_cdc_cursor prod;
> + union smcd_cdc_cursor cons;
> u8 res3[8];
> } __packed;
You're asking for 8-byte alignment of an object you only embed in a
__packed structure, which therefore has arbitary alignment.
It's not going to work.
next prev parent reply other threads:[~2018-11-13 22:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 16:01 [PATCH net 0/5] net/smc: fixes 2018-11-12 Ursula Braun
2018-11-12 16:01 ` [PATCH net 1/5] net/smc: abort CLC connection in smc_release Ursula Braun
2018-11-12 16:01 ` [PATCH net 2/5] net/smc: use queue pair number when matching link group Ursula Braun
2018-11-12 16:01 ` [PATCH net 3/5] net/smc: add SMC-D shutdown signal Ursula Braun
2018-11-12 16:01 ` [PATCH net 4/5] net/smc: atomic SMCD cursor handling Ursula Braun
2018-11-13 22:53 ` David Miller [this message]
2018-11-12 16:01 ` [PATCH net 5/5] net/smc: use after free fix in smc_wr_tx_put_slot() Ursula Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181113.145347.202584017982412625.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=raspl@linux.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=ubraun@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox