From: David Miller <davem@davemloft.net>
To: heiko.carstens@de.ibm.com
Cc: ast@kernel.org, schwidefsky@de.ibm.com, jiong.wang@netronome.com,
linux-s390@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] s390: bpf: fix JMP32 code-gen
Date: Mon, 04 Feb 2019 09:15:08 -0800 (PST) [thread overview]
Message-ID: <20190204.091508.799387970409692312.davem@davemloft.net> (raw)
In-Reply-To: <20190204154455.88687-1-heiko.carstens@de.ibm.com>
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Date: Mon, 4 Feb 2019 16:44:55 +0100
> Commit 626a5f66da0d19 ("s390: bpf: implement jitting of JMP32") added
> JMP32 code-gen support for s390. However it triggers the warning below
> due to some unusual gotos in the original s390 bpf jit code.
>
> Add a couple of additional "is_jmp32" initializations to fix this.
> Also fix the wrong opcode for the "llilf" instruction that was
> introduced with the same commit.
>
> arch/s390/net/bpf_jit_comp.c: In function 'bpf_jit_insn':
> arch/s390/net/bpf_jit_comp.c:248:55: warning: 'is_jmp32' may be used uninitialized in this function [-Wmaybe-uninitialized]
> _EMIT6(op1 | reg(b1, b2) << 16 | (rel & 0xffff), op2 | mask); \
> ^
> arch/s390/net/bpf_jit_comp.c:1211:8: note: 'is_jmp32' was declared here
> bool is_jmp32 = BPF_CLASS(insn->code) == BPF_JMP32;
>
> Fixes: 626a5f66da0d19 ("s390: bpf: implement jitting of JMP32")
> Cc: Jiong Wang <jiong.wang@netronome.com>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2019-02-04 17:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 15:44 [PATCH] s390: bpf: fix JMP32 code-gen Heiko Carstens
2019-02-04 16:15 ` Jiong Wang
2019-02-04 17:15 ` David Miller [this message]
2019-02-04 17:46 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204.091508.799387970409692312.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@kernel.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jiong.wang@netronome.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox