From: Cornelia Huck <cohuck@redhat.com>
To: Farhan Ali <alifm@linux.ibm.com>
Cc: farman@linux.ibm.com, pasic@linux.ibm.com,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v3 2/5] vfio-ccw: Fix memory leak and don't call cp_free in cp_init
Date: Fri, 12 Jul 2019 13:26:22 +0200 [thread overview]
Message-ID: <20190712132622.750cf61f.cohuck@redhat.com> (raw)
In-Reply-To: <3173c4216f4555d9765eb6e4922534982bc820e4.1562854091.git.alifm@linux.ibm.com>
On Thu, 11 Jul 2019 10:28:52 -0400
Farhan Ali <alifm@linux.ibm.com> wrote:
> We don't set cp->initialized to true so calling cp_free
> will just return and not do anything.
>
> Also fix a memory leak where we fail to free a ccwchain
> on an error.
>
> Fixes: 812271b910 ("s390/cio: Squash cp_free() and cp_unpin_free()")
> Signed-off-by: Farhan Ali <alifm@linux.ibm.com>
> ---
> drivers/s390/cio/vfio_ccw_cp.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2019-07-12 11:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 14:28 [PATCH v3 0/5] Some vfio-ccw fixes Farhan Ali
2019-07-11 14:28 ` [PATCH v3 1/5] vfio-ccw: Fix misleading comment when setting orb.cmd.c64 Farhan Ali
2019-07-11 20:30 ` Eric Farman
2019-07-11 14:28 ` [PATCH v3 2/5] vfio-ccw: Fix memory leak and don't call cp_free in cp_init Farhan Ali
2019-07-11 20:30 ` Eric Farman
2019-07-12 11:26 ` Cornelia Huck [this message]
2019-07-11 14:28 ` [PATCH v3 3/5] vfio-ccw: Set pa_nr to 0 if memory allocation fails for pa_iova_pfn Farhan Ali
2019-07-11 14:28 ` [PATCH v3 4/5] vfio-ccw: Don't call cp_free if we are processing a channel program Farhan Ali
2019-07-12 13:19 ` Eric Farman
2019-07-11 14:28 ` [PATCH v3 5/5] vfio-ccw: Update documentation for csch/hsch Farhan Ali
2019-07-12 11:30 ` Cornelia Huck
2019-07-12 13:27 ` Farhan Ali
2019-07-12 13:28 ` Eric Farman
2019-07-15 13:07 ` [PATCH v3 0/5] Some vfio-ccw fixes Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712132622.750cf61f.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alifm@linux.ibm.com \
--cc=farman@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox