From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Petr Tesarik <ptesarik@suse.cz>
Cc: linux-s390@vger.kernel.org, Halil Pasic <pasic@linux.ibm.com>
Subject: Re: Is __dma_direct_alloc_pages broken on s390?
Date: Thu, 18 Jul 2019 13:36:33 +0200 [thread overview]
Message-ID: <20190718113633.GB3581@osiris> (raw)
In-Reply-To: <20190718091700.353b3721@ezekiel.suse.cz>
On Thu, Jul 18, 2019 at 09:17:00AM +0200, Petr Tesarik wrote:
> Hi all,
>
> while looking into DMA allocation, I noticed that
> __dma_direct_optimal_gfp_mask() in kernel/dma/direct.c can probably be
> improved. It uses GFP_DMA if dev->coherent_dma_mask is less than
> DMA_BIT_MASK(ARCH_ZONE_DMA_BITS). There is no s390-specific definition
> of ARCH_ZONE_DMA_BITS. The default is 24 bits, but the DMA zone on s390
> is 31 bits. CCW subchannel devices set sch->dev.coherent_dma_mask to
> DMA_BIT_MASK(31), which is greater than DMA_BIT_MASK(24), so buffers
> are allocated from the Normal zone first.
>
> Would it make sense to set ARCH_ZONE_BITS to 31 on s390, or did I miss
> something?
No, this seems to be broken. Halil, can you look into this and provide
a patch?
next prev parent reply other threads:[~2019-07-18 11:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 7:17 Is __dma_direct_alloc_pages broken on s390? Petr Tesarik
2019-07-18 11:36 ` Heiko Carstens [this message]
2019-07-18 11:51 ` Petr Tesarik
2019-07-18 12:50 ` Halil Pasic
2019-07-18 13:10 ` Christoph Hellwig
2019-07-18 14:27 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718113633.GB3581@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=ptesarik@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox