From: Cornelia Huck <cohuck@redhat.com>
To: Vasily Gorbik <gor@linux.ibm.com>
Cc: linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [PATCH] vfio-ccw: make vfio_ccw_async_region_ops static
Date: Mon, 29 Jul 2019 11:16:40 +0200 [thread overview]
Message-ID: <20190729111640.4c03169c.cohuck@redhat.com> (raw)
In-Reply-To: <patch.git-1c8e853871be.your-ad-here.call-01564389487-ext-4282@work.hours>
On Mon, 29 Jul 2019 10:38:52 +0200
Vasily Gorbik <gor@linux.ibm.com> wrote:
> Since vfio_ccw_async_region_ops is not exported and has no reason to be
> globally visible make it static to avoid the following sparse warning:
> drivers/s390/cio/vfio_ccw_async.c:73:30: warning: symbol 'vfio_ccw_async_region_ops' was not declared. Should it be static?
Fixes: d5afd5d135c8 ("vfio-ccw: add handling for async channel instructions")
>
> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
> ---
> drivers/s390/cio/vfio_ccw_async.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/cio/vfio_ccw_async.c b/drivers/s390/cio/vfio_ccw_async.c
> index 8c1d2357ef5b..7a838e3d7c0f 100644
> --- a/drivers/s390/cio/vfio_ccw_async.c
> +++ b/drivers/s390/cio/vfio_ccw_async.c
> @@ -70,7 +70,7 @@ static void vfio_ccw_async_region_release(struct vfio_ccw_private *private,
>
> }
>
> -const struct vfio_ccw_regops vfio_ccw_async_region_ops = {
> +static const struct vfio_ccw_regops vfio_ccw_async_region_ops = {
> .read = vfio_ccw_async_region_read,
> .write = vfio_ccw_async_region_write,
> .release = vfio_ccw_async_region_release,
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Should I queue this and send a pull request (currently, there's nothing
else pending), or do you want to apply this directly?
next prev parent reply other threads:[~2019-07-29 9:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 8:38 [PATCH] vfio-ccw: make vfio_ccw_async_region_ops static Vasily Gorbik
2019-07-29 9:16 ` Cornelia Huck [this message]
2019-07-29 10:16 ` Vasily Gorbik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729111640.4c03169c.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=gor@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox