public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: kgraul@linux.ibm.com
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org,
	heiko.carstens@de.ibm.com, raspl@linux.ibm.com,
	ubraun@linux.ibm.com
Subject: Re: [PATCH net] net/smc: fix fastopen for non-blocking connect()
Date: Sat, 16 Nov 2019 13:04:22 -0800 (PST)	[thread overview]
Message-ID: <20191116.130422.2084572901433723641.davem@davemloft.net> (raw)
In-Reply-To: <20191115113930.38684-1-kgraul@linux.ibm.com>

From: Karsten Graul <kgraul@linux.ibm.com>
Date: Fri, 15 Nov 2019 12:39:30 +0100

> From: Ursula Braun <ubraun@linux.ibm.com>
> 
> FASTOPEN does not work with SMC-sockets. Since SMC allows fallback to
> TCP native during connection start, the FASTOPEN setsockopts trigger
> this fallback, if the SMC-socket is still in state SMC_INIT.
> But if a FASTOPEN setsockopt is called after a non-blocking connect(),
> this is broken, and fallback does not make sense.
> This change complements
> commit cd2063604ea6 ("net/smc: avoid fallback in case of non-blocking connect")
> and fixes the syzbot reported problem "WARNING in smc_unhash_sk".
> 
> Reported-by: syzbot+8488cc4cf1c9e09b8b86@syzkaller.appspotmail.com
> Fixes: e1bbdd570474 ("net/smc: reduce sock_put() for fallback sockets")
> Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
> Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>

Applied and queued up for -stable, thanks.

      reply	other threads:[~2019-11-16 21:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15 11:39 [PATCH net] net/smc: fix fastopen for non-blocking connect() Karsten Graul
2019-11-16 21:04 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191116.130422.2084572901433723641.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=heiko.carstens@de.ibm.com \
    --cc=kgraul@linux.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=raspl@linux.ibm.com \
    --cc=ubraun@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox