From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Janosch Frank <frankja@linux.vnet.ibm.com>,
KVM <kvm@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] KVM: s390: Also reset registers in sync regs for initial cpu reset
Date: Mon, 16 Mar 2020 12:45:25 +0100 [thread overview]
Message-ID: <20200316124525.3bc099f9.cohuck@redhat.com> (raw)
In-Reply-To: <8bdef3aa-01b5-93a1-c54a-46768d47dfa4@redhat.com>
On Tue, 10 Mar 2020 14:21:23 +0100
David Hildenbrand <david@redhat.com> wrote:
> On 10.03.20 14:12, Christian Borntraeger wrote:
> > When we do the initial CPU reset we must not only clear the registers
> > in the internal data structures but also in kvm_run sync_regs. For
> > modern userspace sync_regs is the only place that it looks at.
> >
> > Cc: stable@vger.kernel.org
>
> # v?
>
> > Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> > ---
> > arch/s390/kvm/kvm-s390.c | 18 +++++++++++++++++-
> > 1 file changed, 17 insertions(+), 1 deletion(-)
> However, I do wonder if that ioctl *originally* was designed for that -
> IOW if this is rally a stable patch or just some change that makes
> sense. IIRC, userspace/QEMU always did the right thing, no? There was no
> documentation about the guarantees AFAIK.
The documentation only refers to the PoP for what is actually reset...
should it also mention the sync regs?
prev parent reply other threads:[~2020-03-16 11:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 13:12 [PATCH v2] KVM: s390: Also reset registers in sync regs for initial cpu reset Christian Borntraeger
2020-03-10 13:21 ` David Hildenbrand
2020-03-10 13:23 ` Christian Borntraeger
2020-03-10 14:55 ` David Hildenbrand
2020-03-16 11:45 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316124525.3bc099f9.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox