From: Cornelia Huck <cohuck@redhat.com>
To: Vasily Gorbik <gor@linux.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Eric Farman <farman@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] vfio-ccw: make vfio_ccw_regops variables declarations static
Date: Thu, 4 Jun 2020 13:27:21 +0200 [thread overview]
Message-ID: <20200604132721.63b11800.cohuck@redhat.com> (raw)
In-Reply-To: <patch.git-a34be7aede18.your-ad-here.call-01591269421-ext-5655@work.hours>
On Thu, 4 Jun 2020 13:20:45 +0200
Vasily Gorbik <gor@linux.ibm.com> wrote:
> Fixes the following sparse warnings:
> drivers/s390/cio/vfio_ccw_chp.c:62:30: warning: symbol 'vfio_ccw_schib_region_ops' was not declared. Should it be static?
> drivers/s390/cio/vfio_ccw_chp.c:117:30: warning: symbol 'vfio_ccw_crw_region_ops' was not declared. Should it be static?
>
> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
> ---
> drivers/s390/cio/vfio_ccw_chp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/s390/cio/vfio_ccw_chp.c b/drivers/s390/cio/vfio_ccw_chp.c
> index 876f6ade51cc..a646fc81c872 100644
> --- a/drivers/s390/cio/vfio_ccw_chp.c
> +++ b/drivers/s390/cio/vfio_ccw_chp.c
> @@ -59,7 +59,7 @@ static void vfio_ccw_schib_region_release(struct vfio_ccw_private *private,
>
> }
>
> -const struct vfio_ccw_regops vfio_ccw_schib_region_ops = {
> +static const struct vfio_ccw_regops vfio_ccw_schib_region_ops = {
> .read = vfio_ccw_schib_region_read,
> .write = vfio_ccw_schib_region_write,
> .release = vfio_ccw_schib_region_release,
> @@ -131,7 +131,7 @@ static void vfio_ccw_crw_region_release(struct vfio_ccw_private *private,
>
> }
>
> -const struct vfio_ccw_regops vfio_ccw_crw_region_ops = {
> +static const struct vfio_ccw_regops vfio_ccw_crw_region_ops = {
> .read = vfio_ccw_crw_region_read,
> .write = vfio_ccw_crw_region_write,
> .release = vfio_ccw_crw_region_release,
Oops.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Feel free to merge this directly.
prev parent reply other threads:[~2020-06-04 11:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 11:27 [PULL v2 00/10] vfio-ccw patches for 5.8 Cornelia Huck
2020-06-03 11:27 ` [PULL v2 01/10] vfio-ccw: Enable transparent CCW IPL from DASD Cornelia Huck
2020-06-03 11:27 ` [PULL v2 02/10] vfio-ccw: document possible errors Cornelia Huck
2020-06-03 11:27 ` [PULL v2 03/10] vfio-ccw: Introduce new helper functions to free/destroy regions Cornelia Huck
2020-06-03 11:27 ` [PULL v2 04/10] vfio-ccw: Register a chp_event callback for vfio-ccw Cornelia Huck
2020-06-03 11:27 ` [PULL v2 05/10] vfio-ccw: Refactor the unregister of the async regions Cornelia Huck
2020-06-03 11:27 ` [PULL v2 06/10] vfio-ccw: Introduce a new schib region Cornelia Huck
2020-06-03 11:27 ` [PULL v2 07/10] vfio-ccw: Refactor IRQ handlers Cornelia Huck
2020-06-03 11:27 ` [PULL v2 08/10] vfio-ccw: Introduce a new CRW region Cornelia Huck
2020-06-03 11:27 ` [PULL v2 09/10] vfio-ccw: Wire up the CRW irq and " Cornelia Huck
2020-06-03 11:27 ` [PULL v2 10/10] vfio-ccw: Add trace for CRW event Cornelia Huck
2020-06-04 11:14 ` [PULL v2 00/10] vfio-ccw patches for 5.8 Vasily Gorbik
2020-06-04 11:20 ` [PATCH] vfio-ccw: make vfio_ccw_regops variables declarations static Vasily Gorbik
2020-06-04 11:27 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604132721.63b11800.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=farman@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox