public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: linux-s390@vger.kernel.org, Sumanth Korikkar <Sumanth.Korikkar@ibm.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Yauheni Kaliuta <yauheni.kaliuta@redhat.com>,
	netdev@vger.kernel.org, bpf@vger.kernel.org,
	Brendan Gregg <brendan.d.gregg@gmail.com>,
	bas@baslab.org, Matheus Marchini <mat@mmarchini.me>,
	Daniel Xu <dxu@dxuuu.xyz>
Subject: bpf: bpf_probe_read helper restriction on s390x
Date: Sun, 5 Jul 2020 21:42:25 +0200	[thread overview]
Message-ID: <20200705194225.GB3356590@krava> (raw)

hi,
with following commit:
  0ebeea8ca8a4 bpf: Restrict bpf_probe_read{, str}() only to archs where they work

the bpf_probe_read BPF helper is restricted on architectures that
have 'non overlapping address space' and select following config:

   select ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE

there's also nice explanation in this commit's changelog:
  6ae08ae3dea2 bpf: Add probe_read_{user, kernel} and probe_read_{user, kernel}_str helpers


We have a problem with bpftrace not working properly on s390x because
bpf_probe_read is no longer available, and bpftrace does not use
bpf_probe_read_(user/kernel) variants yet.

My question is if s390x is 'arch with overlapping address space' and we
could fix this by adding ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE for s390x
or we need to fix bpftrace to detect this, which we probably need to do
in any case ;-)

thanks,
jirka

             reply	other threads:[~2020-07-05 19:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-05 19:42 Jiri Olsa [this message]
2020-07-06  8:54 ` bpf: bpf_probe_read helper restriction on s390x Sumanth Korikkar
     [not found] <OFDA9C9258.BBAFD274-ON0025859D.001E3F9D-C125859D.001E497A@notes.na.collabserv.com>
     [not found] ` <f95739ee-59a9-4dfc-8da0-dfef2c73bd6a@linux.ibm.com>
2020-07-06 10:15   ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200705194225.GB3356590@krava \
    --to=jolsa@redhat.com \
    --cc=Sumanth.Korikkar@ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=ast@kernel.org \
    --cc=bas@baslab.org \
    --cc=bpf@vger.kernel.org \
    --cc=brendan.d.gregg@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=dxu@dxuuu.xyz \
    --cc=linux-s390@vger.kernel.org \
    --cc=mat@mmarchini.me \
    --cc=netdev@vger.kernel.org \
    --cc=yauheni.kaliuta@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox