From: Mark Rutland <mark.rutland@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Vasily Gorbik <gor@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Ingo Molnar <mingo@kernel.org>, Jiri Slaby <jirislaby@kernel.org>,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
Miroslav Benes <mbenes@suse.cz>
Subject: Re: [PATCH v2 0/3] arm64: Convert to ARCH_STACKWALK
Date: Wed, 2 Sep 2020 20:03:06 +0100 [thread overview]
Message-ID: <20200902190306.GB5875@C02TD0UTHF1T.local> (raw)
In-Reply-To: <20200902173803.GE6162@sirena.org.uk>
On Wed, Sep 02, 2020 at 06:38:03PM +0100, Mark Brown wrote:
> On Tue, Sep 01, 2020 at 05:06:26PM +0100, Mark Rutland wrote:
>
> > Just to check, has the skipping logic been tested to work equivalently
> > to what we had before? By inspection I think it should, but since it
> > relies on function call boundaries it always strikes me as fragile.
>
> > If you could confirm that (e.g. with LKDTM perhaps?) that'd be great.
> > Assuming that looks right, for the series:
>
> I've tested this with LKDTM and otherwise and didn't spot any issues
> (and just did a bit of retesting) but it is a pretty manual process so
> it's possible I missed something.
It looks like the case Mirolav pointed out (self-bactrace with NULL
regs) isn't triggered by LKDTM (since it always causes a backtrace from
an exception with non-NULL regs), but we do rely on that elsewhere in
the kernel.
It might be worth adding an LKDTM test to trigger that.
I'll wait for a respin that handles that -- please drop the ack for now.
Thanks,
Mark.
prev parent reply other threads:[~2020-09-02 19:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 12:49 [PATCH v2 0/3] arm64: Convert to ARCH_STACKWALK Mark Brown
2020-08-19 12:49 ` [PATCH v2 1/3] stacktrace: Remove reliable argument from arch_stack_walk() callback Mark Brown
2020-09-02 9:26 ` Miroslav Benes
2020-08-19 12:49 ` [PATCH v2 2/3] arm64: stacktrace: Make stack walk callback consistent with generic code Mark Brown
2020-09-02 9:26 ` Miroslav Benes
2020-08-19 12:49 ` [PATCH v2 3/3] arm64: stacktrace: Convert to ARCH_STACKWALK Mark Brown
2020-09-02 9:32 ` Miroslav Benes
2020-09-02 18:50 ` Mark Rutland
2020-09-10 17:34 ` Mark Brown
2020-09-01 16:06 ` [PATCH v2 0/3] arm64: " Mark Rutland
2020-09-02 17:38 ` Mark Brown
2020-09-02 19:03 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902190306.GB5875@C02TD0UTHF1T.local \
--to=mark.rutland@arm.com \
--cc=borntraeger@de.ibm.com \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox