From: Cornelia Huck <cohuck@redhat.com>
To: Halil Pasic <pasic@linux.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>
Cc: linux-s390@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
Cornelia Huck <cohuck@redhat.com>
Subject: [PATCH RFC 0/2] virtio-ccw: allow to disable legacy virtio
Date: Thu, 4 Mar 2021 14:27:13 +0100 [thread overview]
Message-ID: <20210304132715.1587211-1-cohuck@redhat.com> (raw)
Unlike virtio-pci, virtio-ccw is currently always a transitional
driver (i.e. it always includes support for legacy devices.) The
differences between legacy and virtio-1+ virtio-ccw devices are not
that big (the most interesting things are in common virtio code
anyway.)
It might be beneficial to make support for legacy virtio generally
configurable, in case we want to remove it completely in a future
where we all have flying cars. As a prereq, we need to make it
configurable for virtio-ccw.
Patch 1 introduces a parameter; now that I look at it, it's probably
not that useful (not even for testing), so I'm inclined to drop it
again.
Patch 2 adds a new config symbol for generic legacy virtio support,
which currently does not do anything but being selected by the
legacy options for virtio-pci and virtio-ccw. A virtio-ccw driver
without legacy support will require a revision of 1 or higher to
be supported by the device.
A virtio-ccw driver with legacy turned off works well for me with
transitional devices and fails onlining gracefully for legacy devices
(max_revision=0 in QEMU).
(I also have some code that allows to make devices non-transitional
in QEMU, but I haven't yet found time to polish the patches.)
Cornelia Huck (2):
virtio/s390: add parameter for minimum revision
virtio/s390: make legacy support configurable
arch/s390/Kconfig | 11 ++
drivers/s390/virtio/Makefile | 1 +
drivers/s390/virtio/virtio_ccw.c | 179 ++++++++----------------
drivers/s390/virtio/virtio_ccw_common.h | 113 +++++++++++++++
drivers/s390/virtio/virtio_ccw_legacy.c | 138 ++++++++++++++++++
drivers/virtio/Kconfig | 8 ++
6 files changed, 330 insertions(+), 120 deletions(-)
create mode 100644 drivers/s390/virtio/virtio_ccw_common.h
create mode 100644 drivers/s390/virtio/virtio_ccw_legacy.c
base-commit: cf6acb8bdb1d829b85a4daa2944bf9e71c93f4b9
--
2.26.2
next reply other threads:[~2021-03-04 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 13:27 Cornelia Huck [this message]
2021-03-04 13:27 ` [PATCH RFC 1/2] virtio/s390: add parameter for minimum revision Cornelia Huck
2021-03-04 13:27 ` [PATCH RFC 2/2] virtio/s390: make legacy support configurable Cornelia Huck
2021-05-26 14:34 ` [PATCH RFC 0/2] virtio-ccw: allow to disable legacy virtio Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210304132715.1587211-1-cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox