From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>,
Stefan Haberland <sth@linux.ibm.com>,
Jan Hoeppner <hoeppner@linux.ibm.com>
Cc: Tejun Heo <tj@kernel.org>,
linux-block@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [PATCH 05/11] block: take bd_mutex around delete_partitions in del_gendisk
Date: Tue, 6 Apr 2021 08:22:56 +0200 [thread overview]
Message-ID: <20210406062303.811835-6-hch@lst.de> (raw)
In-Reply-To: <20210406062303.811835-1-hch@lst.de>
There is nothing preventing an ioctl from trying do delete partition
concurrenly with del_gendisk, so take open_mutex to serialize against
that.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/genhd.c | 4 ++++
block/partitions/core.c | 2 ++
2 files changed, 6 insertions(+)
diff --git a/block/genhd.c b/block/genhd.c
index 8303ec67fd7099..e3f3c2321773f9 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -680,7 +680,11 @@ void del_gendisk(struct gendisk *disk)
* disk is marked as dead (GENHD_FL_UP cleared).
*/
down_write(&bdev_lookup_sem);
+
+ mutex_lock(&disk->part0->bd_mutex);
blk_drop_partitions(disk);
+ mutex_unlock(&disk->part0->bd_mutex);
+
fsync_bdev(disk->part0);
__invalidate_device(disk->part0, true);
diff --git a/block/partitions/core.c b/block/partitions/core.c
index 536f7c5bb0b6d2..9fbaec466b516d 100644
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -531,6 +531,8 @@ void blk_drop_partitions(struct gendisk *disk)
struct disk_part_iter piter;
struct block_device *part;
+ lockdep_assert_held(&disk->part0->bd_mutex);
+
disk_part_iter_init(&piter, disk, DISK_PITER_INCL_EMPTY);
while ((part = disk_part_iter_next(&piter)))
delete_partition(part);
--
2.30.1
next prev parent reply other threads:[~2021-04-06 6:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 6:22 partition iteration simplifications Christoph Hellwig
2021-04-06 6:22 ` [PATCH 01/11] dasd: use bdev_disk_changed instead of blk_drop_partitions Christoph Hellwig
2021-04-08 14:31 ` Stefan Haberland
2021-04-06 6:22 ` [PATCH 02/11] block: remove invalidate_partition Christoph Hellwig
2021-04-06 6:22 ` [PATCH 03/11] block: move more syncing and invalidation to delete_partition Christoph Hellwig
2021-04-06 6:22 ` [PATCH 04/11] block: refactor blk_drop_partitions Christoph Hellwig
2021-04-06 6:22 ` Christoph Hellwig [this message]
2021-04-06 6:22 ` [PATCH 06/11] block: simplify partition removal Christoph Hellwig
2021-04-06 6:22 ` [PATCH 07/11] block: simplify partition_overlaps Christoph Hellwig
2021-04-06 6:22 ` [PATCH 08/11] block: simplify printk_all_partitions Christoph Hellwig
2021-04-06 6:23 ` [PATCH 09/11] block: simplify show_partition Christoph Hellwig
2021-04-06 6:23 ` [PATCH 10/11] block: simplify diskstats_show Christoph Hellwig
2021-04-06 6:23 ` [PATCH 11/11] block: remove disk_part_iter Christoph Hellwig
2021-04-08 16:24 ` partition iteration simplifications Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210406062303.811835-6-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hoeppner@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sth@linux.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox