From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
david@redhat.com, thuth@redhat.com, cohuck@redhat.com
Subject: [kvm-unit-tests PATCH v2 2/3] s390x: uv-host: Explain why we set up the home space and remove the space change
Date: Fri, 20 Aug 2021 11:39:59 +0000 [thread overview]
Message-ID: <20210820114000.166527-3-frankja@linux.ibm.com> (raw)
In-Reply-To: <20210820114000.166527-1-frankja@linux.ibm.com>
UV home addresses don't require us to be in home space but we need to
have it set up so hw/fw can use the home asce to translate home
virtual addresses.
Hence we add a comment why we're setting up the home asce and remove
the address space since it's unneeded.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
---
s390x/uv-host.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/s390x/uv-host.c b/s390x/uv-host.c
index 426a67f6..28035707 100644
--- a/s390x/uv-host.c
+++ b/s390x/uv-host.c
@@ -444,13 +444,18 @@ static void test_clear(void)
static void setup_vmem(void)
{
- uint64_t asce, mask;
+ uint64_t asce;
setup_mmu(get_max_ram_size(), NULL);
+ /*
+ * setup_mmu() will enable DAT and set the primary address
+ * space but we need to have a valid home space since UV calls
+ * take home space virtual addresses.
+ *
+ * Hence we just copy the primary asce into the home space.
+ */
asce = stctg(1);
lctlg(13, asce);
- mask = extract_psw_mask() | 0x0000C00000000000UL;
- load_psw_mask(mask);
}
int main(void)
--
2.30.2
next prev parent reply other threads:[~2021-08-20 11:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 11:39 [kvm-unit-tests PATCH v2 0/3] s390x: Cleanup and maintenance Janosch Frank
2021-08-20 11:39 ` [kvm-unit-tests PATCH v2 1/3] lib: s390x: Print addressing related exception information Janosch Frank
2021-08-20 11:48 ` Claudio Imbrenda
2021-08-20 13:36 ` Janosch Frank
2021-08-27 7:06 ` Thomas Huth
2021-08-20 11:39 ` Janosch Frank [this message]
2021-08-27 7:17 ` [kvm-unit-tests PATCH v2 2/3] s390x: uv-host: Explain why we set up the home space and remove the space change Thomas Huth
2021-08-20 11:40 ` [kvm-unit-tests PATCH v2 3/3] lib: s390x: Control register constant cleanup Janosch Frank
2021-08-20 11:49 ` Claudio Imbrenda
2021-08-27 7:20 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210820114000.166527-3-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox