From: Jason Gunthorpe <jgg@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Tony Krowiak <akrowiak@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Harald Freudenberger <freude@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
linux-s390@vger.kernel.org, Halil Pasic <pasic@linux.ibm.com>,
Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH v3] vfio/ap_ops: Convert to use vfio_register_group_dev()
Date: Mon, 23 Aug 2021 11:18:12 -0300 [thread overview]
Message-ID: <20210823141812.GH1672295@nvidia.com> (raw)
In-Reply-To: <20210810083355.GB21036@lst.de>
On Tue, Aug 10, 2021 at 10:33:55AM +0200, Christoph Hellwig wrote:
> > - atomic_inc(&matrix_dev->available_instances);
> > - return -ENOMEM;
> > + ret = -ENOMEM;
> > + goto err_atomic;
>
> Nit: the label naming here is very strange. Somethig like
> err_dec_avaiable would be much more descriptive.
Sure
> > +static struct mdev_driver vfio_ap_matrix_driver = {
> > + .driver = {
> > + .name = "vfio_ap_mdev",
> > + .owner = THIS_MODULE,
> > + .mod_name = KBUILD_MODNAME,
>
> No need to set mod_name.
We talked about this before:
https://lore.kernel.org/kvm/20210326121048.GN2356281@nvidia.com/
Thanks,
Jason
next prev parent reply other threads:[~2021-08-23 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 19:51 [PATCH v3] vfio/ap_ops: Convert to use vfio_register_group_dev() Jason Gunthorpe
2021-08-10 8:33 ` Christoph Hellwig
2021-08-23 14:18 ` Jason Gunthorpe [this message]
2021-08-19 13:55 ` Tony Krowiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210823141812.GH1672295@nvidia.com \
--to=jgg@nvidia.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hch@lst.de \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox