From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
david@redhat.com, thuth@redhat.com, seiden@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH 1/2] lib: s390x: Fix PSW constant
Date: Wed, 13 Oct 2021 12:32:00 +0200 [thread overview]
Message-ID: <20211013123200.19c55ea0@p-imbrenda> (raw)
In-Reply-To: <20211013102722.17160-2-frankja@linux.ibm.com>
On Wed, 13 Oct 2021 10:27:21 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:
> Somehow the ";" got into that patch and now complicates compilation.
> Let's remove it and put the constant in braces.
ouch
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> lib/s390x/asm/arch_def.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h
> index b34aa792..40626d72 100644
> --- a/lib/s390x/asm/arch_def.h
> +++ b/lib/s390x/asm/arch_def.h
> @@ -53,7 +53,7 @@ struct psw {
> #define PSW_MASK_PSTATE 0x0001000000000000UL
> #define PSW_MASK_EA 0x0000000100000000UL
> #define PSW_MASK_BA 0x0000000080000000UL
> -#define PSW_MASK_64 PSW_MASK_BA | PSW_MASK_EA;
> +#define PSW_MASK_64 (PSW_MASK_BA | PSW_MASK_EA)
>
> #define CTL0_LOW_ADDR_PROT (63 - 35)
> #define CTL0_EDAT (63 - 40)
next prev parent reply other threads:[~2021-10-13 10:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 10:27 [kvm-unit-tests PATCH 0/2] s390x: Cleanup and maintenance 3 Janosch Frank
2021-10-13 10:27 ` [kvm-unit-tests PATCH 1/2] lib: s390x: Fix PSW constant Janosch Frank
2021-10-13 10:32 ` Claudio Imbrenda [this message]
2021-10-13 11:17 ` Thomas Huth
2021-10-13 10:27 ` [kvm-unit-tests PATCH 2/2] lib: s390x: snippet.h: Add a few constants that will make our life easier Janosch Frank
2021-10-13 10:35 ` Claudio Imbrenda
2021-10-13 10:38 ` Janosch Frank
2021-10-13 13:15 ` Janis Schoetterl-Glausch
2021-10-13 13:21 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013123200.19c55ea0@p-imbrenda \
--to=imbrenda@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=seiden@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox