From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Linux Kernel Functional Testing <lkft@linaro.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-s390@vger.kernel.org
Subject: [PATCH] s390: add <linux/minmax.h> to <asm/facility.h>
Date: Thu, 28 Oct 2021 17:26:33 -0700 [thread overview]
Message-ID: <20211029002633.31323-1-rdunlap@infradead.org> (raw)
S390's <asm/facility.h> uses the min_t() macro, so it should
include <linux/minmax.h> to avoid build errors.
In file included from arch/s390/pci/pci_insn.c:12:
arch/s390/include/asm/facility.h: In function '__stfle':
arch/s390/include/asm/facility.h:98:22: error: implicit declaration of
function 'min_t' [-Werror=implicit-function-declaration]
98 | nr = min_t(unsigned long, (nr + 1) * 8, size * 8);
arch/s390/include/asm/facility.h:98:28: error: expected expression
before 'unsigned'
98 | nr = min_t(unsigned long, (nr + 1) * 8, size * 8);
Fixes: 4f18d869ffd0 ("s390: fix stfle zero padding")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linux-s390@vger.kernel.org
---
arch/s390/include/asm/facility.h | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20211028.orig/arch/s390/include/asm/facility.h
+++ linux-next-20211028/arch/s390/include/asm/facility.h
@@ -9,6 +9,7 @@
#define __ASM_FACILITY_H
#include <asm/facility-defs.h>
+#include <linux/minmax.h>
#include <linux/string.h>
#include <linux/preempt.h>
#include <asm/lowcore.h>
next reply other threads:[~2021-10-29 0:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 0:26 Randy Dunlap [this message]
2021-10-29 10:21 ` [PATCH] s390: add <linux/minmax.h> to <asm/facility.h> Vasily Gorbik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211029002633.31323-1-rdunlap@infradead.org \
--to=rdunlap@infradead.org \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lkft@linaro.org \
--cc=naresh.kamboju@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox