From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH] s390x: uv: Fix UVC cmd prepare reset name
Date: Thu, 2 Dec 2021 14:28:29 +0100 [thread overview]
Message-ID: <20211202142829.087c8650@p-imbrenda> (raw)
In-Reply-To: <20211202131122.2948-1-frankja@linux.ibm.com>
On Thu, 2 Dec 2021 13:11:22 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:
> The specification and the kernel use UVC_CMD_PREPARE_RESET so let's
> fix our naming up.
>
> The call bit is named correctly but is not the same as the name we use
> on KVM. So let's clear that up too.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> lib/s390x/asm/uv.h | 4 ++--
> s390x/uv-guest.c | 2 +-
> s390x/uv-host.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/s390x/asm/uv.h b/lib/s390x/asm/uv.h
> index 97c90e81..70bf65c4 100644
> --- a/lib/s390x/asm/uv.h
> +++ b/lib/s390x/asm/uv.h
> @@ -39,7 +39,7 @@
> #define UVC_CMD_VERIFY_IMG 0x0302
> #define UVC_CMD_CPU_RESET 0x0310
> #define UVC_CMD_CPU_RESET_INITIAL 0x0311
> -#define UVC_CMD_PERF_CONF_CLEAR_RESET 0x0320
> +#define UVC_CMD_PREPARE_RESET 0x0320
> #define UVC_CMD_CPU_RESET_CLEAR 0x0321
> #define UVC_CMD_CPU_SET_STATE 0x0330
> #define UVC_CMD_SET_UNSHARED_ALL 0x0340
> @@ -66,7 +66,7 @@ enum uv_cmds_inst {
> BIT_UVC_CMD_CPU_RESET = 15,
> BIT_UVC_CMD_CPU_RESET_INITIAL = 16,
> BIT_UVC_CMD_CPU_SET_STATE = 17,
> - BIT_UVC_CMD_PREPARE_CLEAR_RESET = 18,
> + BIT_UVC_CMD_PREPARE_RESET = 18,
> BIT_UVC_CMD_CPU_PERFORM_CLEAR_RESET = 19,
> BIT_UVC_CMD_UNSHARE_ALL = 20,
> BIT_UVC_CMD_PIN_PAGE_SHARED = 21,
> diff --git a/s390x/uv-guest.c b/s390x/uv-guest.c
> index 44ad2154..99120cae 100644
> --- a/s390x/uv-guest.c
> +++ b/s390x/uv-guest.c
> @@ -142,7 +142,7 @@ static struct {
> { "verify", UVC_CMD_VERIFY_IMG, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_VERIFY_IMG },
> { "cpu reset", UVC_CMD_CPU_RESET, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_CPU_RESET },
> { "cpu initial reset", UVC_CMD_CPU_RESET_INITIAL, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_CPU_RESET_INITIAL },
> - { "conf clear reset", UVC_CMD_PERF_CONF_CLEAR_RESET, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_PREPARE_CLEAR_RESET },
> + { "prepare clear reset", UVC_CMD_PREPARE_RESET, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_PREPARE_RESET },
> { "cpu clear reset", UVC_CMD_CPU_RESET_CLEAR, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_CPU_PERFORM_CLEAR_RESET },
> { "cpu set state", UVC_CMD_CPU_SET_STATE, sizeof(struct uv_cb_cpu_set_state), BIT_UVC_CMD_CPU_SET_STATE },
> { "pin shared", UVC_CMD_PIN_PAGE_SHARED, sizeof(struct uv_cb_cfs), BIT_UVC_CMD_PIN_PAGE_SHARED },
> diff --git a/s390x/uv-host.c b/s390x/uv-host.c
> index 92a41069..de2e4850 100644
> --- a/s390x/uv-host.c
> +++ b/s390x/uv-host.c
> @@ -55,7 +55,7 @@ static struct cmd_list cmds[] = {
> { "verify", UVC_CMD_VERIFY_IMG, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_VERIFY_IMG },
> { "cpu reset", UVC_CMD_CPU_RESET, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_CPU_RESET },
> { "cpu initial reset", UVC_CMD_CPU_RESET_INITIAL, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_CPU_RESET_INITIAL },
> - { "conf clear reset", UVC_CMD_PERF_CONF_CLEAR_RESET, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_PREPARE_CLEAR_RESET },
> + { "conf clear reset", UVC_CMD_PREPARE_RESET, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_PREPARE_RESET },
> { "cpu clear reset", UVC_CMD_CPU_RESET_CLEAR, sizeof(struct uv_cb_nodata), BIT_UVC_CMD_CPU_PERFORM_CLEAR_RESET },
> { "cpu set state", UVC_CMD_CPU_SET_STATE, sizeof(struct uv_cb_cpu_set_state), BIT_UVC_CMD_CPU_SET_STATE },
> { "pin shared", UVC_CMD_PIN_PAGE_SHARED, sizeof(struct uv_cb_cfs), BIT_UVC_CMD_PIN_PAGE_SHARED },
prev parent reply other threads:[~2021-12-02 13:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 13:11 [kvm-unit-tests PATCH] s390x: uv: Fix UVC cmd prepare reset name Janosch Frank
2021-12-02 13:28 ` Claudio Imbrenda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211202142829.087c8650@p-imbrenda \
--to=imbrenda@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox