From: Nico Boehr <nrb@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
david@redhat.com, thuth@redhat.com, frankja@linux.ibm.com,
Nico Boehr <nrb@linux.ibm.com>
Subject: [PATCH kvm-unit-tests 2/2] s390x: diag288: Improve readability
Date: Fri, 17 Dec 2021 11:31:37 +0100 [thread overview]
Message-ID: <20211217103137.1293092-3-nrb@linux.ibm.com> (raw)
In-Reply-To: <20211217103137.1293092-1-nrb@linux.ibm.com>
Use a more descriptive name instead of the magic number 424 (address of
restart new PSW in the lowcore).
In addition, add a comment to make it more obvious what the ASM snippet
does.
Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
---
s390x/diag288.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/s390x/diag288.c b/s390x/diag288.c
index da7b06c365bf..a2c263e38338 100644
--- a/s390x/diag288.c
+++ b/s390x/diag288.c
@@ -94,12 +94,15 @@ static void test_bite(void)
/* Arm watchdog */
lc->restart_new_psw.mask = extract_psw_mask() & ~PSW_MASK_EXT;
diag288(CODE_INIT, 15, ACTION_RESTART);
+ /* Wait for restart interruption */
asm volatile(" larl 0, 1f\n"
- " stg 0, 424\n"
+ " stg 0, %[restart_new_psw]\n"
"0: nop\n"
" j 0b\n"
"1:"
- : : : "0");
+ :
+ : [restart_new_psw] "T" (lc->restart_new_psw.addr)
+ : "0");
report_pass("restart");
}
--
2.31.1
next prev parent reply other threads:[~2021-12-17 10:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 10:31 [PATCH kvm-unit-tests 0/2] s390x: diag288: Improve readability Nico Boehr
2021-12-17 10:31 ` [PATCH kvm-unit-tests 1/2] s390x: diag288: Add missing clobber Nico Boehr
2021-12-17 13:47 ` Thomas Huth
2021-12-17 14:16 ` Janosch Frank
2021-12-17 14:23 ` Claudio Imbrenda
2021-12-17 14:24 ` Thomas Huth
2021-12-17 10:31 ` Nico Boehr [this message]
2021-12-17 11:08 ` [PATCH kvm-unit-tests 2/2] s390x: diag288: Improve readability Heiko Carstens
2021-12-17 14:15 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211217103137.1293092-3-nrb@linux.ibm.com \
--to=nrb@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox