From: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
To: virtualization@lists.linux-foundation.org
Cc: Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
Vadim Pasternak <vadimp@nvidia.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Cornelia Huck <cohuck@redhat.com>,
Halil Pasic <pasic@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Johannes Berg <johannes.berg@intel.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Vincent Whitchurch <vincent.whitchurch@axis.com>,
linux-um@lists.infradead.org, netdev@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
kvm@vger.kernel.org, bpf@vger.kernel.org
Subject: [PATCH v9 01/32] virtio: add helper virtqueue_get_vring_max_size()
Date: Wed, 6 Apr 2022 11:43:15 +0800 [thread overview]
Message-ID: <20220406034346.74409-2-xuanzhuo@linux.alibaba.com> (raw)
In-Reply-To: <20220406034346.74409-1-xuanzhuo@linux.alibaba.com>
Record the maximum queue num supported by the device.
virtio-net can display the maximum (supported by hardware) ring size in
ethtool -g eth0.
When the subsequent patch implements vring reset, it can judge whether
the ring size passed by the driver is legal based on this.
Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
---
arch/um/drivers/virtio_uml.c | 1 +
drivers/platform/mellanox/mlxbf-tmfifo.c | 2 ++
drivers/remoteproc/remoteproc_virtio.c | 2 ++
drivers/s390/virtio/virtio_ccw.c | 3 +++
drivers/virtio/virtio_mmio.c | 2 ++
drivers/virtio/virtio_pci_legacy.c | 2 ++
drivers/virtio/virtio_pci_modern.c | 2 ++
drivers/virtio/virtio_ring.c | 14 ++++++++++++++
drivers/virtio/virtio_vdpa.c | 2 ++
include/linux/virtio.h | 2 ++
10 files changed, 32 insertions(+)
diff --git a/arch/um/drivers/virtio_uml.c b/arch/um/drivers/virtio_uml.c
index ba562d68dc04..904993d15a85 100644
--- a/arch/um/drivers/virtio_uml.c
+++ b/arch/um/drivers/virtio_uml.c
@@ -945,6 +945,7 @@ static struct virtqueue *vu_setup_vq(struct virtio_device *vdev,
goto error_create;
}
vq->priv = info;
+ vq->num_max = num;
num = virtqueue_get_vring_size(vq);
if (vu_dev->protocol_features &
diff --git a/drivers/platform/mellanox/mlxbf-tmfifo.c b/drivers/platform/mellanox/mlxbf-tmfifo.c
index 38800e86ed8a..1ae3c56b66b0 100644
--- a/drivers/platform/mellanox/mlxbf-tmfifo.c
+++ b/drivers/platform/mellanox/mlxbf-tmfifo.c
@@ -959,6 +959,8 @@ static int mlxbf_tmfifo_virtio_find_vqs(struct virtio_device *vdev,
goto error;
}
+ vq->num_max = vring->num;
+
vqs[i] = vq;
vring->vq = vq;
vq->priv = vring;
diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c
index 70ab496d0431..7611755d0ae2 100644
--- a/drivers/remoteproc/remoteproc_virtio.c
+++ b/drivers/remoteproc/remoteproc_virtio.c
@@ -125,6 +125,8 @@ static struct virtqueue *rp_find_vq(struct virtio_device *vdev,
return ERR_PTR(-ENOMEM);
}
+ vq->num_max = len;
+
rvring->vq = vq;
vq->priv = rvring;
diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c
index d35e7a3f7067..468da60b56c5 100644
--- a/drivers/s390/virtio/virtio_ccw.c
+++ b/drivers/s390/virtio/virtio_ccw.c
@@ -529,6 +529,9 @@ static struct virtqueue *virtio_ccw_setup_vq(struct virtio_device *vdev,
err = -ENOMEM;
goto out_err;
}
+
+ vq->num_max = info->num;
+
/* it may have been reduced */
info->num = virtqueue_get_vring_size(vq);
diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
index 56128b9c46eb..a41abc8051b9 100644
--- a/drivers/virtio/virtio_mmio.c
+++ b/drivers/virtio/virtio_mmio.c
@@ -390,6 +390,8 @@ static struct virtqueue *vm_setup_vq(struct virtio_device *vdev, unsigned index,
goto error_new_virtqueue;
}
+ vq->num_max = num;
+
/* Activate the queue */
writel(virtqueue_get_vring_size(vq), vm_dev->base + VIRTIO_MMIO_QUEUE_NUM);
if (vm_dev->version == 1) {
diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c
index 34141b9abe27..b68934fe6b5d 100644
--- a/drivers/virtio/virtio_pci_legacy.c
+++ b/drivers/virtio/virtio_pci_legacy.c
@@ -135,6 +135,8 @@ static struct virtqueue *setup_vq(struct virtio_pci_device *vp_dev,
if (!vq)
return ERR_PTR(-ENOMEM);
+ vq->num_max = num;
+
q_pfn = virtqueue_get_desc_addr(vq) >> VIRTIO_PCI_QUEUE_ADDR_SHIFT;
if (q_pfn >> 32) {
dev_err(&vp_dev->pci_dev->dev,
diff --git a/drivers/virtio/virtio_pci_modern.c b/drivers/virtio/virtio_pci_modern.c
index 5455bc041fb6..86d301f272b8 100644
--- a/drivers/virtio/virtio_pci_modern.c
+++ b/drivers/virtio/virtio_pci_modern.c
@@ -218,6 +218,8 @@ static struct virtqueue *setup_vq(struct virtio_pci_device *vp_dev,
if (!vq)
return ERR_PTR(-ENOMEM);
+ vq->num_max = num;
+
/* activate the queue */
vp_modern_set_queue_size(mdev, index, virtqueue_get_vring_size(vq));
vp_modern_queue_address(mdev, index, virtqueue_get_desc_addr(vq),
diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index 962f1477b1fa..b87130c8f312 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -2371,6 +2371,20 @@ void vring_transport_features(struct virtio_device *vdev)
}
EXPORT_SYMBOL_GPL(vring_transport_features);
+/**
+ * virtqueue_get_vring_max_size - return the max size of the virtqueue's vring
+ * @_vq: the struct virtqueue containing the vring of interest.
+ *
+ * Returns the max size of the vring.
+ *
+ * Unlike other operations, this need not be serialized.
+ */
+unsigned int virtqueue_get_vring_max_size(struct virtqueue *_vq)
+{
+ return _vq->num_max;
+}
+EXPORT_SYMBOL_GPL(virtqueue_get_vring_max_size);
+
/**
* virtqueue_get_vring_size - return the size of the virtqueue's vring
* @_vq: the struct virtqueue containing the vring of interest.
diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c
index 7767a7f0119b..39e4c08eb0f2 100644
--- a/drivers/virtio/virtio_vdpa.c
+++ b/drivers/virtio/virtio_vdpa.c
@@ -183,6 +183,8 @@ virtio_vdpa_setup_vq(struct virtio_device *vdev, unsigned int index,
goto error_new_virtqueue;
}
+ vq->num_max = max_num;
+
/* Setup virtqueue callback */
cb.callback = virtio_vdpa_virtqueue_cb;
cb.private = info;
diff --git a/include/linux/virtio.h b/include/linux/virtio.h
index 72292a62cd90..d59adc4be068 100644
--- a/include/linux/virtio.h
+++ b/include/linux/virtio.h
@@ -31,6 +31,7 @@ struct virtqueue {
struct virtio_device *vdev;
unsigned int index;
unsigned int num_free;
+ unsigned int num_max;
void *priv;
};
@@ -80,6 +81,7 @@ bool virtqueue_enable_cb_delayed(struct virtqueue *vq);
void *virtqueue_detach_unused_buf(struct virtqueue *vq);
+unsigned int virtqueue_get_vring_max_size(struct virtqueue *vq);
unsigned int virtqueue_get_vring_size(struct virtqueue *vq);
bool virtqueue_is_broken(struct virtqueue *vq);
--
2.31.0
next prev parent reply other threads:[~2022-04-06 13:31 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 3:43 [PATCH v9 00/32] virtio pci support VIRTIO_F_RING_RESET (refactor vring) Xuan Zhuo
2022-04-06 3:43 ` Xuan Zhuo [this message]
2022-04-12 2:41 ` [PATCH v9 01/32] virtio: add helper virtqueue_get_vring_max_size() Jason Wang
2022-04-13 2:24 ` Xuan Zhuo
2022-04-14 9:16 ` Jason Wang
2022-04-06 3:43 ` [PATCH v9 02/32] virtio: struct virtio_config_ops add callbacks for queue_reset Xuan Zhuo
2022-04-12 2:47 ` Jason Wang
2022-04-12 2:49 ` Jason Wang
2022-04-06 3:43 ` [PATCH v9 03/32] virtio_ring: update the document of the virtqueue_detach_unused_buf for queue reset Xuan Zhuo
2022-04-12 2:49 ` Jason Wang
2022-04-06 3:43 ` [PATCH v9 04/32] virtio_ring: remove the arg vq of vring_alloc_desc_extra() Xuan Zhuo
2022-04-12 2:53 ` Jason Wang
2022-04-06 3:43 ` [PATCH v9 05/32] virtio_ring: extract the logic of freeing vring Xuan Zhuo
2022-04-12 2:58 ` Jason Wang
2022-04-06 3:43 ` [PATCH v9 06/32] virtio_ring: split: extract the logic of alloc queue Xuan Zhuo
2022-04-12 3:22 ` Jason Wang
2022-04-13 6:52 ` Xuan Zhuo
2022-04-06 3:43 ` [PATCH v9 07/32] virtio_ring: split: extract the logic of alloc state and extra Xuan Zhuo
2022-04-12 3:26 ` Jason Wang
2022-04-13 6:48 ` Xuan Zhuo
2022-04-06 3:43 ` [PATCH v9 08/32] virtio_ring: split: extract the logic of attach vring Xuan Zhuo
2022-04-12 3:31 ` Jason Wang
2022-04-13 6:44 ` Xuan Zhuo
2022-04-06 3:43 ` [PATCH v9 09/32] virtio_ring: split: extract the logic of vq init Xuan Zhuo
2022-04-12 3:42 ` Jason Wang
2022-04-13 7:04 ` Xuan Zhuo
2022-04-06 3:43 ` [PATCH v9 10/32] virtio_ring: split: introduce virtqueue_reinit_split() Xuan Zhuo
2022-04-12 5:49 ` Jason Wang
2022-04-06 3:43 ` [PATCH v9 11/32] virtio_ring: split: introduce virtqueue_resize_split() Xuan Zhuo
2022-04-12 5:53 ` Jason Wang
2022-04-13 6:32 ` Xuan Zhuo
2022-04-06 3:43 ` [PATCH v9 12/32] virtio_ring: packed: extract the logic of alloc queue Xuan Zhuo
2022-04-12 6:28 ` Jason Wang
2022-04-13 3:23 ` Xuan Zhuo
2022-04-14 9:18 ` Jason Wang
2022-04-06 3:43 ` [PATCH v9 13/32] virtio_ring: packed: extract the logic of alloc state and extra Xuan Zhuo
2022-04-06 3:43 ` [PATCH v9 14/32] virtio_ring: packed: extract the logic of attach vring Xuan Zhuo
2022-04-06 3:43 ` [PATCH v9 15/32] virtio_ring: packed: extract the logic of vq init Xuan Zhuo
2022-04-06 3:43 ` [PATCH v9 16/32] virtio_ring: packed: introduce virtqueue_reinit_packed() Xuan Zhuo
2022-04-06 3:43 ` [PATCH v9 17/32] virtio_ring: packed: introduce virtqueue_resize_packed() Xuan Zhuo
2022-04-06 3:43 ` [PATCH v9 18/32] virtio_ring: introduce virtqueue_resize() Xuan Zhuo
2022-04-12 6:41 ` Jason Wang
2022-04-13 12:14 ` Xuan Zhuo
2022-04-13 12:21 ` Xuan Zhuo
2022-04-06 3:43 ` [PATCH v9 19/32] virtio_pci: struct virtio_pci_common_cfg add queue_notify_data Xuan Zhuo
2022-04-06 3:43 ` [PATCH v9 20/32] virtio: queue_reset: add VIRTIO_F_RING_RESET Xuan Zhuo
2022-04-06 3:43 ` [PATCH v9 21/32] virtio_pci: queue_reset: update struct virtio_pci_common_cfg and option functions Xuan Zhuo
2022-04-12 6:43 ` Jason Wang
2022-04-06 3:43 ` [PATCH v9 22/32] virtio_pci: queue_reset: extract the logic of active vq for modern pci Xuan Zhuo
2022-04-12 6:58 ` Jason Wang
2022-04-14 6:22 ` Xuan Zhuo
2022-04-14 9:37 ` Jason Wang
2022-04-06 3:43 ` [PATCH v9 23/32] virtio_pci: queue_reset: support VIRTIO_F_RING_RESET Xuan Zhuo
2022-04-12 7:07 ` Jason Wang
2022-04-13 3:21 ` Xuan Zhuo
2022-04-14 9:17 ` Jason Wang
2022-04-13 8:48 ` Xuan Zhuo
2022-04-06 3:43 ` [PATCH v9 24/32] virtio: find_vqs() add arg sizes Xuan Zhuo
2022-04-12 7:10 ` Jason Wang
2022-04-06 3:43 ` [PATCH v9 25/32] virtio_pci: support the arg sizes of find_vqs() Xuan Zhuo
2022-04-12 7:12 ` Jason Wang
2022-04-06 3:43 ` [PATCH v9 26/32] virtio_mmio: " Xuan Zhuo
2022-04-12 7:13 ` Jason Wang
2022-04-06 3:43 ` [PATCH v9 27/32] virtio: add helper virtio_find_vqs_ctx_size() Xuan Zhuo
2022-04-12 7:15 ` Jason Wang
2022-04-06 3:43 ` [PATCH v9 28/32] virtio_net: set the default max ring size by find_vqs() Xuan Zhuo
2022-04-12 7:18 ` Jason Wang
2022-04-06 3:43 ` [PATCH v9 29/32] virtio_net: get ringparam by virtqueue_get_vring_max_size() Xuan Zhuo
2022-04-12 7:19 ` Jason Wang
2022-04-06 3:43 ` [PATCH v9 30/32] virtio_net: split free_unused_bufs() Xuan Zhuo
2022-04-06 3:43 ` [PATCH v9 31/32] virtio_net: support rx/tx queue resize Xuan Zhuo
2022-04-13 8:00 ` Jason Wang
2022-04-13 8:35 ` Xuan Zhuo
2022-04-14 9:30 ` Jason Wang
2022-04-15 2:18 ` Xuan Zhuo
2022-04-15 5:53 ` Jason Wang
2022-04-15 9:17 ` Xuan Zhuo
2022-04-18 7:57 ` Jason Wang
2022-04-18 3:21 ` Xuan Zhuo
2022-04-18 7:49 ` Jason Wang
2022-04-18 8:48 ` Xuan Zhuo
2022-04-06 3:43 ` [PATCH v9 32/32] virtio_net: support set_ringparam Xuan Zhuo
2022-04-13 8:06 ` Jason Wang
2022-04-26 9:55 ` [PATCH v9 00/32] virtio pci support VIRTIO_F_RING_RESET (refactor vring) Michael S. Tsirkin
2022-04-26 9:59 ` Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406034346.74409-2-xuanzhuo@linux.alibaba.com \
--to=xuanzhuo@linux.alibaba.com \
--cc=agordeev@linux.ibm.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=ast@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=borntraeger@linux.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=cohuck@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=gor@linux.ibm.com \
--cc=hawk@kernel.org \
--cc=hca@linux.ibm.com \
--cc=hdegoede@redhat.com \
--cc=jasowang@redhat.com \
--cc=jdike@addtoit.com \
--cc=johannes.berg@intel.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=markgross@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=richard@nod.at \
--cc=svens@linux.ibm.com \
--cc=vadimp@nvidia.com \
--cc=vincent.whitchurch@axis.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox