From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
david@redhat.com, thuth@redhat.com, seiden@linux.ibm.com,
nrb@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH v3 11/11] s390x: Restore registers in diag308_load_reset() error path
Date: Thu, 21 Apr 2022 13:59:04 +0200 [thread overview]
Message-ID: <20220421135904.6ac14c7e@p-imbrenda> (raw)
In-Reply-To: <20220421101130.23107-12-frankja@linux.ibm.com>
On Thu, 21 Apr 2022 10:11:30 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:
> In case of an error we'll currently return with the wrong values in
> gr0 and gr1. Let's fix that by restoring the registers before setting
> the return value and branching to the return address.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> s390x/cpu.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/s390x/cpu.S b/s390x/cpu.S
> index 82b5e25d..0bd8c0e3 100644
> --- a/s390x/cpu.S
> +++ b/s390x/cpu.S
> @@ -34,6 +34,7 @@ diag308_load_reset:
> stg %r15, GEN_LC_SW_INT_GRS + 15 * 8
> /* Do the reset */
> diag %r0,%r2,0x308
> + RESTORE_REGS_STACK
> /* Failure path */
> xgr %r2, %r2
> br %r14
next prev parent reply other threads:[~2022-04-21 11:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 10:11 [kvm-unit-tests PATCH v3 00/11] s390x: Cleanup and maintenance 4 Janosch Frank
2022-04-21 10:11 ` [kvm-unit-tests PATCH v3 01/11] lib: s390x: hardware: Add host_is_qemu() function Janosch Frank
2022-04-21 10:11 ` [kvm-unit-tests PATCH v3 02/11] s390x: css: Skip if we're not run by qemu Janosch Frank
2022-04-21 10:11 ` [kvm-unit-tests PATCH v3 03/11] s390x: diag308: Only test subcode 2 under QEMU Janosch Frank
2022-04-21 10:11 ` [kvm-unit-tests PATCH v3 04/11] s390x: pfmf: Initialize pfmf_r1 union on declaration Janosch Frank
2022-04-21 10:11 ` [kvm-unit-tests PATCH v3 05/11] s390x: snippets: asm: Add license and copyright headers Janosch Frank
2022-04-21 10:11 ` [kvm-unit-tests PATCH v3 06/11] s390x: pv-diags: Cleanup includes Janosch Frank
2022-04-21 10:11 ` [kvm-unit-tests PATCH v3 07/11] s390x: css: " Janosch Frank
2022-04-21 10:11 ` [kvm-unit-tests PATCH v3 08/11] s390x: iep: " Janosch Frank
2022-04-21 10:11 ` [kvm-unit-tests PATCH v3 09/11] s390x: mvpg: " Janosch Frank
2022-04-21 10:11 ` [kvm-unit-tests PATCH v3 10/11] s390x: uv-host: Fix pgm tests Janosch Frank
2022-04-21 11:13 ` Nico Boehr
2022-04-21 10:11 ` [kvm-unit-tests PATCH v3 11/11] s390x: Restore registers in diag308_load_reset() error path Janosch Frank
2022-04-21 11:59 ` Claudio Imbrenda [this message]
2022-04-21 11:59 ` [kvm-unit-tests PATCH v3 00/11] s390x: Cleanup and maintenance 4 Claudio Imbrenda
2022-04-21 12:39 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421135904.6ac14c7e@p-imbrenda \
--to=imbrenda@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=seiden@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox