Re: [kvm-unit-tests PATCH v4 1/1] s390x: add migration test for storage keys

[Claudio Imbrenda <imbrenda@linux.ibm.com>]

On Fri, 10 Jun 2022 10:49:28 +0200
Janosch Frank <frankja@linux.ibm.com> wrote:

[...]

> > +		key_to_set = i * 2;
> > +		set_storage_key(pagebuf[i], key_to_set, 1);
> > +	}
> > +
> > +	puts("Please migrate me, then press return\n");
> > +	(void)getchar();
> > +
> > +	for (i = 0; i < NUM_PAGES; i++) {
> > +		report_prefix_pushf("page %d", i);
> > +
> > +		actual_key.val = get_storage_key(pagebuf[i]);  
> 
> iske is nice but I think it would also be interesting to check if the 
> actual memory protection was carried over. The iske check is enough for 
> now though.

we had that in a previous version, but I think it's overkill, there are
separate tests to check for key protection, I think?

also, under TCG the value of the storage keys is migrated, but there is
no protection, this makes the test unnecessarily complex

[...]