Re: [kvm-unit-tests PATCH 2/3] s390x: pv: Test sie entry intercepts and validities

[Claudio Imbrenda <imbrenda@linux.ibm.com>]

On Tue, 21 Feb 2023 10:22:13 +0100
Janosch Frank <frankja@linux.ibm.com> wrote:

[...]

> >> +	/* Yes I know this is not reliable as one cpu might overwrite it */  
> > 
> > the wording in this comment could be improved  
> 
> How about:
> This might not be fully reliable but it should be sufficient for our 
> current goals.

looks good, thanks

> 
> [...]
> 
> >> +	report_prefix_push("shared");
> >> +	sie(&vm);
> >> +	/* Guest indicates that it has shared the new lowcore */
> >> +	report(vm.sblk->icptcode == ICPT_PV_NOTIFY && vm.sblk->ipa == 0x8302 &&
> >> +	       vm.sblk->ipb == 0x50000000 && vm.save_area.guest.grs[5] == 0x44,
> >> +	       "intercept values");
> >> +
> >> +	uv_export(vm.sblk->mso + lc_off);
> >> +	uv_export(vm.sblk->mso + lc_off + PAGE_SIZE);  
> > 
> > why are you not testing both pages individually here, like you did
> > above?  
> 
> Hmm, I don't think there was a reason behind this. I'll add it.
> 
> [...]