public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Nico Boehr <nrb@linux.ibm.com>
Cc: borntraeger@linux.ibm.com, frankja@linux.ibm.com,
	shuah@kernel.org, kvm@vger.kernel.org,
	linux-s390@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v1 0/2] KVM: s390: CMMA migration selftest and small bugfix
Date: Thu, 23 Mar 2023 15:38:03 +0100	[thread overview]
Message-ID: <20230323153803.7ab4038d@p-imbrenda> (raw)
In-Reply-To: <20230208144827.131300-1-nrb@linux.ibm.com>

On Wed,  8 Feb 2023 15:48:25 +0100
Nico Boehr <nrb@linux.ibm.com> wrote:

> Add a new selftest for CMMA migration. Also fix a small issue found during
> development of the test.
> 
> Nico Boehr (2):
>   KVM: s390: selftests: add selftest for CMMA migration
>   KVM: s390: fix KVM_S390_GET_CMMA_BITS for GFNs in memslot holes
> 
>  arch/s390/kvm/kvm-s390.c                      |   4 +
>  tools/testing/selftests/kvm/Makefile          |   1 +
>  tools/testing/selftests/kvm/s390x/cmma_test.c | 679 ++++++++++++++++++
>  3 files changed, 684 insertions(+)
>  create mode 100644 tools/testing/selftests/kvm/s390x/cmma_test.c
> 

the series looks good in general, but I would swap the order and have
the fix first, and the tests after

  parent reply	other threads:[~2023-03-23 14:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08 14:48 [PATCH v1 0/2] KVM: s390: CMMA migration selftest and small bugfix Nico Boehr
2023-02-08 14:48 ` [PATCH v1 2/2] KVM: s390: fix KVM_S390_GET_CMMA_BITS for GFNs in memslot holes Nico Boehr
2023-03-23 12:36   ` Claudio Imbrenda
2023-02-08 14:48 ` [PATCH v1 1/2] KVM: s390: selftests: add selftest for CMMA migration Nico Boehr
2023-03-23 14:36   ` Claudio Imbrenda
2023-03-24 13:31     ` Nico Boehr
2023-03-24 13:58       ` Claudio Imbrenda
2023-03-22 15:00 ` [PATCH v1 0/2] KVM: s390: CMMA migration selftest and small bugfix Nico Boehr
2023-03-22 15:06   ` Claudio Imbrenda
2023-03-23 14:38 ` Claudio Imbrenda [this message]
2023-03-24 13:32   ` Nico Boehr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230323153803.7ab4038d@p-imbrenda \
    --to=imbrenda@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=frankja@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=nrb@linux.ibm.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox