From: Pierre Morel <pmorel@linux.ibm.com>
To: linux-s390@vger.kernel.org
Cc: frankja@linux.ibm.com, thuth@redhat.com, kvm@vger.kernel.org,
imbrenda@linux.ibm.com, david@redhat.com, nrb@linux.ibm.com,
nsg@linux.ibm.com, cohuck@redhat.com
Subject: [kvm-unit-tests PATCH v5 1/2] s390x: sclp: treat system as single processor when read_info is NULL
Date: Thu, 1 Jun 2023 18:45:36 +0200 [thread overview]
Message-ID: <20230601164537.31769-2-pmorel@linux.ibm.com> (raw)
In-Reply-To: <20230601164537.31769-1-pmorel@linux.ibm.com>
When a test abort()s before SCLP read info is completed, the assertion
on read_info in sclp_read_info() will fail. Since abort() eventually
calls smp_teardown() which in turn calls sclp_get_cpu_num(), this will
cause an infinite abort() chain, causing the test to hang.
Fix this by considering the system single processor when read_info is
missing.
Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
Reviewed-by: Nico Boehr <nrb@linux.ibm.com>
---
lib/s390x/sclp.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/lib/s390x/sclp.c b/lib/s390x/sclp.c
index acdc8a9..adf357b 100644
--- a/lib/s390x/sclp.c
+++ b/lib/s390x/sclp.c
@@ -119,8 +119,15 @@ void sclp_read_info(void)
int sclp_get_cpu_num(void)
{
- assert(read_info);
- return read_info->entries_cpu;
+ if (read_info)
+ return read_info->entries_cpu;
+ /*
+ * Don't abort here if read_info is NULL since abort() calls
+ * smp_teardown() which eventually calls this function and thus
+ * causes an infinite abort() chain, causing the test to hang.
+ * Since we obviously have at least one CPU, just return one.
+ */
+ return 1;
}
CPUEntry *sclp_get_cpu_entries(void)
--
2.31.1
next prev parent reply other threads:[~2023-06-01 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 16:45 [kvm-unit-tests PATCH v5 0/2] Fixing infinite loop on SCLP READ SCP INFO error Pierre Morel
2023-06-01 16:45 ` Pierre Morel [this message]
2023-06-01 16:45 ` [kvm-unit-tests PATCH v5 2/2] s390x: sclp: Implement extended-length-SCCB facility Pierre Morel
2023-06-01 16:58 ` Pierre Morel
2023-06-02 8:24 ` [kvm-unit-tests PATCH v5 0/2] Fixing infinite loop on SCLP READ SCP INFO error Nico Boehr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601164537.31769-2-pmorel@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox