From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Nico Boehr <nrb@linux.ibm.com>
Cc: Janosch Frank <frankja@linux.ibm.com>,
thuth@redhat.com, kvm@vger.kernel.org,
linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v3 1/6] lib: s390x: introduce bitfield for PSW mask
Date: Wed, 7 Jun 2023 18:19:28 +0200 [thread overview]
Message-ID: <20230607181928.75d20898@p-imbrenda> (raw)
In-Reply-To: <168615337335.127716.6745745533225595281@t14-nrb>
On Wed, 07 Jun 2023 17:56:13 +0200
Nico Boehr <nrb@linux.ibm.com> wrote:
> Quoting Janosch Frank (2023-06-01 09:42:48)
> [...]
> > I've come to like static asserts for huge structs and bitfields since
> > they can safe you from a *lot* of headaches.
>
> I generally agree and I add a _Static_assert but I want to mention the
> usefulness is a bit limited in this case, since we have a bitfield inside a
> union. So it only really helps if you manage to exceed the size of mask.
better than nothing :)
if the struct becomes too big, the assert will catch it
>
> There really is no way around the stuff I put in the selftests.
>
> I could of course try to make that code _Static_asserts but it will not be
> pretty.
I think just a couple of asserts to make sure things aren't __too__
crazy would be good enough
next prev parent reply other threads:[~2023-06-07 16:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 7:01 [kvm-unit-tests PATCH v3 0/6] s390x: Add support for running guests without MSO/MSL Nico Boehr
2023-06-01 7:01 ` [kvm-unit-tests PATCH v3 1/6] lib: s390x: introduce bitfield for PSW mask Nico Boehr
2023-06-01 7:42 ` Janosch Frank
2023-06-05 10:35 ` Claudio Imbrenda
2023-06-05 14:23 ` Janosch Frank
2023-06-07 15:56 ` Nico Boehr
2023-06-07 16:19 ` Claudio Imbrenda [this message]
2023-06-01 7:01 ` [kvm-unit-tests PATCH v3 2/6] s390x: add function to set DAT mode for all interrupts Nico Boehr
2023-06-05 8:42 ` Janosch Frank
2023-06-15 12:44 ` Nico Boehr
2023-06-01 7:01 ` [kvm-unit-tests PATCH v3 3/6] s390x: sie: switch to home space mode before entering SIE Nico Boehr
2023-06-05 9:03 ` Janosch Frank
2023-06-15 13:09 ` Nico Boehr
2023-06-01 7:02 ` [kvm-unit-tests PATCH v3 4/6] s390x: lib: don't forward PSW when handling exception in SIE Nico Boehr
2023-06-05 9:11 ` Janosch Frank
2023-06-05 10:42 ` Claudio Imbrenda
2023-06-01 7:02 ` [kvm-unit-tests PATCH v3 5/6] s390x: lib: sie: don't reenter SIE on pgm int Nico Boehr
2023-06-05 9:30 ` Janosch Frank
2023-06-05 10:44 ` Claudio Imbrenda
2023-06-30 14:59 ` Nico Boehr
2023-06-30 15:04 ` Janosch Frank
2023-06-30 15:53 ` Claudio Imbrenda
2023-06-01 7:02 ` [kvm-unit-tests PATCH v3 6/6] s390x: add a test for SIE without MSO/MSL Nico Boehr
2023-06-05 9:57 ` Janosch Frank
2023-07-10 14:29 ` Nico Boehr
2023-07-10 15:05 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607181928.75d20898@p-imbrenda \
--to=imbrenda@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox